linux-kernel - Re: [PATCH 2/2] x86/PCI: Slightly simplify pirq_convert_irt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.2305190334330.50034@angie.orcam.me.uk>
Date:   Fri, 19 May 2023 12:24:17 +0100 (BST)
From:   "Maciej W. Rozycki" <macro@...am.me.uk>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
cc:     Bjorn Helgaas <bhelgaas@...gle.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
        "H. Peter Anvin" <hpa@...or.com>, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-pci@...r.kernel.org
Subject: Re: [PATCH 2/2] x86/PCI: Slightly simplify
 pirq_convert_irt_table()

On Sat, 6 May 2023, Christophe JAILLET wrote:

> 'size' if computed twice. *ir and *it being the same, the result is the
> same as well.

 There is no `it' data object in this function; I presume you meant `rt'. 
Then `*ir' and `*rt' are of a different type each, hence the calculations 
are not the same.  If they were the same, the function wouldn't be needed 
at all in the first place.  Therefore, NAK.

> While at it, also use struct_size() which is less verbose, more robust and
> more informative.

 This might be a valuable clean-up, thank you, please submit separately.

  Maciej