linux-kernel - Re: [PATCH] init: Add bdev fs printk if mount_block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKwvOdkppYFVnnjBetUK=KVw5dg6_NcgX73mnjOSFpA_XtEd5w@mail.gmail.com>
Date:   Fri, 19 May 2023 08:58:48 -0700
From:   Nick Desaulniers <ndesaulniers@...gle.com>
To:     Angus Chen <angus.chen@...uarmicro.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        "masahiroy@...nel.org" <masahiroy@...nel.org>,
        "vbabka@...e.cz" <vbabka@...e.cz>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "paulmck@...nel.org" <paulmck@...nel.org>,
        "rppt@...nel.org" <rppt@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Al Viro <viro@...iv.linux.org.uk>
Subject: Re: [PATCH] init: Add bdev fs printk if mount_block_root failed

On Thu, May 18, 2023 at 11:34 PM Angus Chen <angus.chen@...uarmicro.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Nick Desaulniers <ndesaulniers@...gle.com>
> > Sent: Friday, May 19, 2023 4:36 AM
> > To: Andrew Morton <akpm@...ux-foundation.org>; Angus Chen
> > <angus.chen@...uarmicro.com>
> > Cc: masahiroy@...nel.org; vbabka@...e.cz; peterz@...radead.org;
> > paulmck@...nel.org; rppt@...nel.org; linux-kernel@...r.kernel.org; Al Viro
> > <viro@...iv.linux.org.uk>
> > Subject: Re: [PATCH] init: Add bdev fs printk if mount_block_root failed
> >
> > I wish the commit message showed an example of the panic after the
> > patch, to contrast the before vs. after.
> en ,Did a need to send a v2 or just let it go this time?

Nah, it's fine. LGTM

> The information is print:
> [    1.570841] VFS: Cannot open root device "vda" or unknown-block(253,0): error -19
> [    1.571513] Please append a correct "root=" boot option; here are the available partitions:
> [    1.572056] fd00          256000 vda
> [    1.572058]  driver: virtio_blk
> [    1.572525] List of all bdev filesystem:
> [    1.572780]  ext2
> [    1.572781]
> [    1.573027] Kernel panic - not syncing: VFS: Unable to mount root fs on unknown-block(253,0)
>
> Or:
> [    1.510467] VFS: Cannot open root device "vda" or unknown-block(253,0): error -19
> [    1.512033] Please append a correct "root=" boot option; here are the available partitions:
> [    1.513724] fd00          256000 vda
> [    1.513731]  driver: virtio_blk
> [    1.514280] Can't find any bdev filesystem!
> [    1.514540] Kernel panic - not syncing: VFS: Unable to mount root fs on unknown-block(253,0)

-- 
Thanks,
~Nick Desaulniers