linux-kernel - Re: [PATCH] mm: page_alloc: set sysctl_lowmem_reserve

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8b102796-2a90-de0c-9889-4b8b8aa8a98d@huawei.com>
Date:   Fri, 19 May 2023 09:19:49 +0800
From:   Kefeng Wang <wangkefeng.wang@...wei.com>
To:     Tom Rix <trix@...hat.com>, <akpm@...ux-foundation.org>
CC:     <linux-mm@...ck.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm: page_alloc: set sysctl_lowmem_reserve_ratio
 storage-class-specifier to static



On 2023/5/18 22:11, Tom Rix wrote:
> smatch reports
> mm/page_alloc.c:247:5: warning: symbol
>    'sysctl_lowmem_reserve_ratio' was not declared. Should it be static?
> 
> This variable is only used in its defining file, so it should be static
> 
> Signed-off-by: Tom Rix <trix@...hat.com>
> ---
>   mm/page_alloc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 

Missing this one, Reviewed-by: Kefeng Wang <wangkefeng.wang@...wei.com>

> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 1023f41de2fb..8032fffa425a 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -244,7 +244,7 @@ static void __free_pages_ok(struct page *page, unsigned int order,
>    * TBD: should special case ZONE_DMA32 machines here - in those we normally
>    * don't need any ZONE_NORMAL reservation
>    */
> -int sysctl_lowmem_reserve_ratio[MAX_NR_ZONES] = {
> +static int sysctl_lowmem_reserve_ratio[MAX_NR_ZONES] = {
>   #ifdef CONFIG_ZONE_DMA
>   	[ZONE_DMA] = 256,
>   #endif