linux-kernel - [PATCH] drivers/fsi/scom: Return -EFAULT if copy fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230519013710.34954-1-suhui@nfschina.com>
Date:   Fri, 19 May 2023 09:37:10 +0800
From:   Su Hui <suhui@...china.com>
To:     Jeremy Kerr <jk@...abs.org>, Joel Stanley <joel@....id.au>,
        Alistar Popple <alistair@...ple.id.au>,
        Eddie James <eajames@...ux.ibm.com>
Cc:     eajames@...ibm.com, cbostic@...ux.vnet.ibm.com,
        gregkh@...uxfoundation.org, linux-fsi@...ts.ozlabs.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Su Hui <suhui@...china.com>
Subject: [PATCH] drivers/fsi/scom: Return -EFAULT if copy fails

The copy_to/from_user() functions return the number of bytes remaining
to be copied, but we want to return -EFAULT to the user.

Fixes: 680ca6dcf5c2 ("drivers/fsi: Add SCOM FSI client device driver")
Signed-off-by: Su Hui <suhui@...china.com>
---
 drivers/fsi/fsi-scom.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/fsi/fsi-scom.c b/drivers/fsi/fsi-scom.c
index bcb756dc9866..caaf7738eb98 100644
--- a/drivers/fsi/fsi-scom.c
+++ b/drivers/fsi/fsi-scom.c
@@ -335,7 +335,7 @@ static ssize_t scom_read(struct file *filep, char __user *buf, size_t len,
 	if (rc)
 		dev_dbg(dev, "copy to user failed:%d\n", rc);
 
-	return rc ? rc : len;
+	return rc ? -EFAULT : len;
 }
 
 static ssize_t scom_write(struct file *filep, const char __user *buf,
-- 
2.30.2