linux-kernel - RE: [PATCH v1 2/3] usb: phy: Add driver for the Realtek SoC USB 2.0/3.0 PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 20 May 2023 05:18:30 +0000
From:   Stanley Chang[昌育德] 
        <stanley_chang@...ltek.com>
To:     Vinod Koul <vkoul@...nel.org>, Arnd Bergmann <arnd@...db.de>
CC:     Paul Cercueil <paul@...pouillou.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Kishon Vijay Abraham I <kishon@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Alan Stern <stern@...land.harvard.edu>,
        Ray Chi <raychi@...gle.com>,
        "Bagas Sanjaya" <bagasdotme@...il.com>,
        Eugeniu Rosca <erosca@...adit-jv.com>,
        Michael Grzeschik <m.grzeschik@...gutronix.de>,
        Matthias Kaehlcke <mka@...omium.org>,
        Flavio Suligoi <f.suligoi@...m.it>,
        Mathias Nyman <mathias.nyman@...ux.intel.com>,
        Bhuvanesh Surachari <Bhuvanesh_Surachari@...tor.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        "linux-phy@...ts.infradead.org" <linux-phy@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>
Subject: RE: [PATCH v1 2/3] usb: phy: Add driver for the Realtek SoC USB 2.0/3.0 PHY

Hi Vinod,

> The is correct, phy interfaces can be improved upon and have been added
> upon as and when we have users.
> 
> FWIW there are already usb phy drivers in Generic phy susbystem, so you need
> to really justify why you need a new interface?
> 

I will reference the us phy drivers in drivers/phy.
Is using usb phy in drivers/phy the right choice?
As the following as:
drivers/phy/ti/phy-twl4030-usb.c
drivers/phy/ti/phy-omap-usb2.c
drivers/phy/ti/phy-dm816x-usb.c
drivers/phy/phy-lgm-usb.c
drivers/phy/tegra/xusb.c
drivers/phy/motorola/phy-cpcap-usb.c

Thanks,
Stanley