linux-kernel - Re: Re: [PATCH 1/2] tools/nolibc: riscv: Fix up load/store instructions for rv32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230520100510.31605-1-falcon@tinylab.org>
Date:   Sat, 20 May 2023 18:05:10 +0800
From:   Zhangjin Wu <falcon@...ylab.org>
To:     w@....eu
Cc:     aou@...s.berkeley.edu, falcon@...ylab.org,
        linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org,
        palmer@...osinc.com, paul.walmsley@...ive.com, paulmck@...nel.org
Subject: Re: Re: [PATCH 1/2] tools/nolibc: riscv: Fix up load/store instructions for rv32

> On Sat, May 20, 2023 at 05:11:44PM +0800, Zhangjin Wu wrote:
> > Hi, Willy
> > 
> > This is a full commit message for this patch:
> > 
> > When compile for rv32, we got such error:
> > 
> > ---
> > 
> > nolibc/sysroot/riscv/include/arch.h:190: Error: unrecognized opcode `ld a4,0(a3)'
> > nolibc/sysroot/riscv/include/arch.h:194: Error: unrecognized opcode `sd a3,%lo(_auxv)(a4)'
> > nolibc/sysroot/riscv/include/arch.h:196: Error: unrecognized opcode `sd a2,%lo(environ)(a3)'
> > 
> > Refer to arch/riscv/include/asm/asm.h and add REG_L/REG_S macros here to let
> > rv32 use its own lw/sw instructions.
> > 
> > ---
> 
> That's fine, thank you!
> 
> > I will send a new version with the above full message for you, wait for a
> > while, very sorry ;-)
> 
> Don't waste your time resending, I can perfectly take that one and
> put it into the series.
>

Thanks very much, just found the first `---` is in the wrong line, please
remove the '---' lines manually ;-)

    When compile nolibc application for rv32, we got such errors:
    
    nolibc/sysroot/riscv/include/arch.h:190: Error: unrecognized opcode `ld a4,0(a3)'
    nolibc/sysroot/riscv/include/arch.h:194: Error: unrecognized opcode `sd a3,%lo(_auxv)(a4)'
    nolibc/sysroot/riscv/include/arch.h:196: Error: unrecognized opcode `sd a2,%lo(environ)(a3)'
    
    Refer to arch/riscv/include/asm/asm.h and add REG_L/REG_S macros here to let
    rv32 uses its own lw/sw instructions.

Btw, I wrote some new comments for the 2nd __NR_lseek patch, it is:

    riscv uses the generic include/uapi/asm-generic/unistd.h, it has code
    like this:
    
        #if __BITS_PER_LONG == 64 && !defined(__SYSCALL_COMPAT)
        #define __NR_lseek __NR3264_lseek
        #else
        #define __NR_llseek __NR3264_lseek
        #endif
    
    There is no __NR_lseek for rv32, use __NR_llseek instead.
    
    This code is based on sysdeps/unix/sysv/linux/lseek.c of glibc.

The preceeding 4 white spaces are not required for real commit messages.

Best Regards,
Zhangjin Wu

> Thanks!
> Willy