linux-kernel - Re: [PATCH v4 2/3] iio: pressure: Honeywell mprls0025pa pressure sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 20 May 2023 17:35:36 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Andreas Klinger <ak@...klinger.de>
Cc:     linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
        Lars-Peter Clausen <lars@...afoo.de>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Angel Iglesias <ang.iglesiasg@...il.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/3] iio: pressure: Honeywell mprls0025pa pressure
 sensor

On Tue, 16 May 2023 12:28:18 +0200
Andreas Klinger <ak@...klinger.de> wrote:

> Hi Jonathan,
> 
> thanks for your review. I have one comment.
> 
> Jonathan Cameron <jic23@...nel.org> schrieb am Sa, 06. Mai 17:04:
> > > +	int                     scale;          /* int part of scale */
> > > +	int                     scale2;         /* nano part of scale */
> > > +	int                     offset;         /* int part of offset */
> > > +	int                     offset2;        /* nano part of offset */
> > > +	struct gpio_desc	*gpiod_reset;	/* reset */
> > > +	int			irq;		/* end of conversion irq */  
> > 
> > Only needed in probe, no need for a copy in here.  
> 
> It's also used in mpr_read_pressure() to distinguish the two possible operation
> modes:
> - waiting for an interrupt
> - reading in a loop until status indicates data ready
> 
Oops.  Thanks for pointing that out!

> Andreas