linux-kernel - Re: [PATCH v4 1/3] spi: add SPI_MOSI_IDLE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEktqctboF3=ykVNtPsifcmHzF6dWwoEcVh+O4H1u-R=TT6gHg@mail.gmail.com>
Date:   Sat, 20 May 2023 20:21:15 +0200
From:   Börge Strümpfel <boerge.struempfel@...il.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Fabio Estevam <festevam@...il.com>, bstruempfel@...ratronik.de,
        amit.kumar-mahapatra@....com, broonie@...nel.org,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        NXP Linux Team <linux-imx@....com>,
        linux-spi@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/3] spi: add SPI_MOSI_IDLE_LOW mode bit

Thank you for you response

Am Do., 18. Mai 2023 um 12:58 Uhr schrieb Andy Shevchenko
<andy.shevchenko@...il.com>:
>
> On Thu, May 18, 2023 at 3:27 AM Börge Strümpfel
> <boerge.struempfel@...il.com> wrote:
> > Am Do., 18. Mai 2023 um 01:53 Uhr schrieb Fabio Estevam <festevam@...il.com>:
>
> ...
>
>
> > Okay. I have begun to implement this. During this, I noticed, that if
> > I called the new option
> > "--mosi-idle-low", the alignment of the help-lines (and in the c code
> > itself) would break.
> > Should I therefore shorten the option name by using an abbreviation
> > like "--mil", which is
> > probably not very helpful as a "full option name", or should I touch
> > all the other lines and
> > insert necessary spaces, such that they are aligned once more? (And if
> > so, should I do
> > this in a seperate patch, preparing the addition of the new options?)
>
> It's a user space tool where not so strict rules of commit splitting
> apply (as far as I know), I would go with indention fixes in the same
> patch that adds the option.
>

That's good to know. I will do that.

> ...
>
> > > > While looking through the code, I noticed, that the latest two
> > > > additions to the spi->mode
> > > > (SPI_3WIRE_HIZ and SPI_RX_CPHA_FLIP) are also missing from this tool. Is this
> > > > by design, or should they then be included as well?
> > >
> > > Looks like these two are missing and would be good to get them included as well.
> >
> > Okay. Should this be a separate patch, or should I add the support for
> > all 3 mode bits in
> > one commit?
>
> Split them logically. Are they from the same group of bits? No? then split.
>
Yes they are actually from the same group of bits. Therefore I'll add
them all in the same patch.
> --
> With Best Regards,
> Andy Shevchenko