lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:   Sat, 20 May 2023 13:12:48 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     linux-kernel@...r.kernel.org
Cc:     Randy Dunlap <rdunlap@...radead.org>,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        Georgi Djakov <djakov@...nel.org>
Subject: [PATCH] interconnect: add license and exports to fix build errors

icc-clk.c should have a MODULE_LICENSE() and export its register and
unregister functions to prevent build errors, so add them.

ERROR: modpost: missing MODULE_LICENSE() in drivers/interconnect/icc-clk.o
ERROR: modpost: "icc_clk_unregister" [drivers/clk/qcom/clk-cbf-8996.ko] undefined!
ERROR: modpost: "icc_clk_register" [drivers/clk/qcom/clk-cbf-8996.ko] undefined!

Fixes: 0ac2a08f42ce ("interconnect: add clk-based icc provider support")
Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
Cc: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc: Georgi Djakov <djakov@...nel.org>
---
 drivers/interconnect/icc-clk.c |    6 ++++++
 1 file changed, 6 insertions(+)

diff -- a/drivers/interconnect/icc-clk.c b/drivers/interconnect/icc-clk.c
--- a/drivers/interconnect/icc-clk.c
+++ b/drivers/interconnect/icc-clk.c
@@ -5,8 +5,10 @@
 
 #include <linux/clk.h>
 #include <linux/device.h>
+#include <linux/export.h>
 #include <linux/interconnect-clk.h>
 #include <linux/interconnect-provider.h>
+#include <linux/module.h>
 
 struct icc_clk_node {
 	struct clk *clk;
@@ -146,6 +148,7 @@ err:
 
 	return ERR_PTR(ret);
 }
+EXPORT_SYMBOL_GPL(icc_clk_register);
 
 /**
  * icc_clk_unregister() - unregister a previously registered clk interconnect provider
@@ -166,3 +169,6 @@ void icc_clk_unregister(struct icc_provi
 			clk_disable_unprepare(qn->clk);
 	}
 }
+EXPORT_SYMBOL_GPL(icc_clk_unregister);
+
+MODULE_LICENSE("GPL");

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ