linux-kernel - Re: [PATCH] net: macb: use correct __be32 and _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20230520020035.216060-1-minhuadotchen@gmail.com>
Date:   Sat, 20 May 2023 10:00:35 +0800
From:   Min-Hua Chen <minhuadotchen@...il.com>
To:     kuba@...nel.org
Cc:     claudiu.beznea@...rochip.com, davem@...emloft.net,
        edumazet@...gle.com, linux-kernel@...r.kernel.org,
        minhuadotchen@...il.com, netdev@...r.kernel.org,
        nicolas.ferre@...rochip.com, pabeni@...hat.com
Subject: Re: [PATCH] net: macb: use correct __be32 and __be16 types

>On Sat, 20 May 2023 06:19:39 +0800 Min-Hua Chen wrote:
>> This patch fixes the following sparse warnings. No functional changes.
>> 
>> Use cpu_to_be16() and cpu_to_be32() to convert constants before comparing
>> them with __be16 type of psrc/pdst and __be32 type of ip4src/ip4dst.
>> Apply be16_to_cpu() in GEM_BFINS().
>
>same story as with your stmmac patch, the warning is a false positive

yes, the same story and let's discuss this in the stmmac thread [1].

[1] https://lore.kernel.org/lkml/20230520015527.215952-1-minhuadotchen@gmail.com/

thanks,
Min-Hua