linux-kernel - Re: [PATCH v1] usb: dwc2: add pci_device_id driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55bcc7fc-274b-b364-9a0d-431d7f4d215e@loongson.cn>
Date:   Sat, 20 May 2023 11:33:30 +0800
From:   zhuyinbo <zhuyinbo@...ngson.cn>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     kernel test robot <lkp@...el.com>,
        Minas Harutyunyan <hminas@...opsys.com>,
        Bjorn Helgaas <helgaas@...nel.org>, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
        oe-kbuild-all@...ts.linux.dev, Jianmin Lv <lvjianmin@...ngson.cn>,
        wanghongliang@...ngson.cn, Liu Peibao <liupeibao@...ngson.cn>,
        loongson-kernel@...ts.loongnix.cn, zhuyinbo@...ngson.cn
Subject: Re: [PATCH v1] usb: dwc2: add pci_device_id driver_data parse support



在 2023/5/19 下午5:49, Greg Kroah-Hartman 写道:
> On Fri, May 19, 2023 at 03:13:20PM +0800, zhuyinbo wrote:
>>
>>
>> 在 2023/5/19 上午1:52, kernel test robot 写道:
>>> Hi Yinbo,
>>>
>>> kernel test robot noticed the following build errors:
>>>
>>> [auto build test ERROR on pci/next]
>>> [also build test ERROR on pci/for-linus westeri-thunderbolt/next linus/master v6.4-rc2 next-20230518]
>>> [cannot apply to usb/usb-testing usb/usb-next usb/usb-linus]
>>> [If your patch is applied to the wrong git tree, kindly drop us a note.
>>> And when submitting patch, we suggest to use '--base' as documented in
>>> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>>>
>>> url:    https://github.com/intel-lab-lkp/linux/commits/Yinbo-Zhu/usb-dwc2-add-pci_device_id-driver_data-parse-support/20230518-173721
>>> base:   https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git next
>>> patch link:    https://lore.kernel.org/r/20230518092240.8023-1-zhuyinbo%40loongson.cn
>>> patch subject: [PATCH v1] usb: dwc2: add pci_device_id driver_data parse support
>>> config: powerpc-allmodconfig
>>> compiler: powerpc-linux-gcc (GCC) 12.1.0
>>> reproduce (this is a W=1 build):
>>>           wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>>>           chmod +x ~/bin/make.cross
>>>           # https://github.com/intel-lab-lkp/linux/commit/3ff56448e1442fe8b1e72651a8d4d6e1086ece32
>>>           git remote add linux-review https://github.com/intel-lab-lkp/linux
>>>           git fetch --no-tags linux-review Yinbo-Zhu/usb-dwc2-add-pci_device_id-driver_data-parse-support/20230518-173721
>>>           git checkout 3ff56448e1442fe8b1e72651a8d4d6e1086ece32
>>>           # save the config file
>>>           mkdir build_dir && cp config build_dir/.config
>>>           COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=powerpc olddefconfig
>>>           COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash
>>>
>>> If you fix the issue, kindly add following tag where applicable
>>> | Reported-by: kernel test robot <lkp@...el.com>
>>> | Closes: https://lore.kernel.org/oe-kbuild-all/202305190105.O6ycxCti-lkp@intel.com/
>>>
>>> All errors (new ones prefixed by >>, old ones prefixed by <<):
>>>
>>>>> ERROR: modpost: "dwc2_pci_ids" [drivers/usb/dwc2/dwc2_pci.ko] undefined!
>>
>>
>> I test it was set dwc2 pci driver as built-in, so no error, this compile
>> error was that dwc2_pci_ids not export when driver as module and I will
>> add EXPORT_SYMBOL_GPL(dwc2_pci_ids) to fix that compile issue.
> 
> Again, no, please do this properly, no one should ever be walking a pci
> id list by hand like this...


okay, I got it. But I don't seem to have found a good way to set
dwc2 elements yet for pci device, in addition, I have some alalysis in
another mail loop. please you check in your free time.

Thanks!
Yinbo.