linux-kernel - Re: [PATCH 1/2] amdgpu: validate drm_amdgpu_gem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPaKu7SQ0NkDVN3NNRoJxGRQ8x2T2uXcxZJEkt7g2CkEzVU3Sg@mail.gmail.com>
Date:   Sun, 21 May 2023 11:49:54 -0700
From:   Chia-I Wu <olvaffe@...il.com>
To:     Alex Deucher <alexdeucher@...il.com>
Cc:     dri-devel@...ts.freedesktop.org, Philip Yang <Philip.Yang@....com>,
        Kefeng Wang <wangkefeng.wang@...wei.com>,
        amd-gfx@...ts.freedesktop.org,
        Arunpravin Paneer Selvam <Arunpravin.PaneerSelvam@....com>,
        Suren Baghdasaryan <surenb@...gle.com>,
        Felix Kuehling <Felix.Kuehling@....com>,
        "Pan, Xinhui" <Xinhui.Pan@....com>, linux-kernel@...r.kernel.org,
        Mukul Joshi <mukul.joshi@....com>,
        Marek Olšák <marek.olsak@....com>,
        Luben Tuikov <luben.tuikov@....com>,
        Yang Li <yang.lee@...ux.alibaba.com>,
        Danijel Slivka <danijel.slivka@....com>,
        Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>
Subject: Re: [PATCH 1/2] amdgpu: validate drm_amdgpu_gem_va addrs for all ops

On Thu, May 18, 2023 at 1:12 PM Alex Deucher <alexdeucher@...il.com> wrote:
>
> On Wed, May 17, 2023 at 5:27 PM Chia-I Wu <olvaffe@...il.com> wrote:
> >
> > On Tue, May 9, 2023 at 11:33 AM Chia-I Wu <olvaffe@...il.com> wrote:
> > >
> > > Extend the address and size validations to AMDGPU_VA_OP_UNMAP and
> > > AMDGPU_VA_OP_CLEAR by moving the validations to amdgpu_gem_va_ioctl.
> > >
> > > Internal users of amdgpu_vm_bo_map are no longer validated but they
> > > should be fine.
> > >
> > > Userspace (radeonsi and radv) seems fine as well.
> > Does this series make sense?
>
> I think so, I haven't had a chance to go through this too closely yet,
> but amdgpu_vm_bo_map() is used by ROCm as well so we'd need to make
> sure that removing the checks in patch 1 wouldn't affect that path as
> well.  The changes in patch 2 look good.  Also, these patches are
> missing your SOB.
Indeed.  kfd_ioctl_alloc_memory_of_gpu, for example, does not validate
va.  I need to keep the validation in amdgpu_vm_bo_map for it at
least.  I guess it is more ideal for kfd_ioctl_alloc_memory_of_gpu to
validate, but I am not familiar with amdkfd..

I can keep the existing validations, and duplicate them in
amdgpu_gem_va_ioctl to cover AMDGPU_VA_OP_UNMAP/AMDGPU_VA_OP_CLEAR.

>
> Thanks,
>
> Alex
>
>
> Alex