linux-kernel - Re: [PATCH RESEND 01/13] scsi: ncr53c8xx: Use default @max_active for hostdata->work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ea7df70c-01ab-2ad3-a775-542afc6f21d6@linux-m68k.org>
Date:   Sun, 21 May 2023 16:42:15 +1000 (AEST)
From:   Finn Thain <fthain@...ux-m68k.org>
To:     Tejun Heo <tj@...nel.org>
cc:     jiangshanlai@...il.com, linux-kernel@...r.kernel.org,
        kernel-team@...a.com, Michael Schmitz <schmitzmic@...il.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org
Subject: Re: [PATCH RESEND 01/13] scsi: ncr53c8xx: Use default @max_active
 for hostdata->work_q

On Sat, 20 May 2023, Tejun Heo wrote:

> From: Tejun Heo <tj@...nel.org>
> Subject: scsi: ncr53c8xx: Use default @max_active for hostdata->work_q
> 

This driver is normally referred to as ncr5380 or NCR5380. (It doesn't 
support any other member of the 538x family.)

> hostdata->work_q only hosts a single work item, hostdata->main_task, and
> thus doesn't need explicit concurrency limit. Let's use the default
> @max_active. This doesn't cost anything and clearly expresses that
> @max_active doesn't matter.
> 
> Signed-off-by: Tejun Heo <tj@...nel.org>

Acked-by: Finn Thain <fthain@...ux-m68k.org>

> Cc: Finn Thain <fthain@...ux-m68k.org>
> Cc: Michael Schmitz <schmitzmic@...il.com>
> Cc: "James E.J. Bottomley" <jejb@...ux.ibm.com>
> Cc: "Martin K. Petersen" <martin.petersen@...cle.com>
> Cc: linux-scsi@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> ---
> Hello,
> 
> Resending because I screwed up the cc list in the original posting. The
> whole series can be viewed at:
> 
>   http://lkml.kernel.org/r/20230509015032.3768622-1-tj@kernel.org
> 
> It's not a must but it'd be great if I can route this through the 
> workqueue tree so that it can go together with other related and 
> followup cleanups.
> 
> Thanks.
> 

No objection from me. I guess it's Martin's call?