linux-kernel - Re: [PATCH next] drm/amdgpu: Fix unsigned comparison with zero in gmc_v9_0_process

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADnq5_Oqnc1vHNp5QFNA82W4Ja+ua+Xj6Feku06VG6O6bkDztg@mail.gmail.com>
Date:   Mon, 22 May 2023 11:02:25 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
Cc:     Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        "Pan, Xinhui" <Xinhui.Pan@....com>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>,
        Felix Kuehling <Felix.Kuehling@....com>,
        Hawking Zhang <Hawking.Zhang@....com>, Le Ma <le.ma@....com>,
        Lijo Lazar <lijo.lazar@....com>,
        Mukul Joshi <mukul.joshi@....com>,
        Rajneesh Bhardwaj <rajneesh.bhardwaj@....com>,
        Graham Sider <Graham.Sider@....com>,
        amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org, dan.carpenter@...aro.org,
        kernel-janitors@...r.kernel.org, error27@...il.com
Subject: Re: [PATCH next] drm/amdgpu: Fix unsigned comparison with zero in gmc_v9_0_process_interrupt()

Applied.  Thanks!

On Mon, May 22, 2023 at 3:30 AM Harshit Mogalapalli
<harshit.m.mogalapalli@...cle.com> wrote:
>
> Smatch warns:
>         drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c:579:
>         unsigned 'xcc_id' is never less than zero.
>
> gfx_v9_4_3_ih_to_xcc_inst() returns negative numbers as well.
> Fix this by changing type of xcc_id to int.
>
> Fixes: faf96b9b602d ("drm/amdgpu: correct the vmhub index when page fault occurs")
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
> ---
> This is from static analysis, only compile tested.
> ---
>  drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> index f70e666cecf2..1e8b2aaa48c1 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> @@ -557,8 +557,8 @@ static int gmc_v9_0_process_interrupt(struct amdgpu_device *adev,
>         const char *hub_name;
>         u64 addr;
>         uint32_t cam_index = 0;
> -       int ret;
> -       uint32_t node_id, xcc_id = 0;
> +       int ret, xcc_id = 0;
> +       uint32_t node_id;
>
>         node_id = entry->node_id;
>
> --
> 2.38.1
>