linux-kernel - Re: [PATCH v2 4/4] ARM: dts: qcom: msm8226: Add IMEM node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4828763.31r3eYUQgx@z3ntu.xyz>
Date:   Mon, 22 May 2023 18:11:17 +0200
From:   Luca Weiss <luca@...tu.xyz>
To:     linux-arm-msm@...r.kernel.org,
        ~postmarketos/upstreaming@...ts.sr.ht
Cc:     ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
        Matti Lehtimäki <matti.lehtimaki@...il.com>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Matti Lehtimäki <matti.lehtimaki@...il.com>
Subject: Re: [PATCH v2 4/4] ARM: dts: qcom: msm8226: Add IMEM node

On Samstag, 20. Mai 2023 14:19:33 CEST Matti Lehtimäki wrote:
> This enables userspace to signal the bootloader to go into the
> bootloader or recovery mode.
> 
> The magic values can be found in both the downstream kernel and the LK
> kernel (bootloader).
> 
> Signed-off-by: Matti Lehtimäki <matti.lehtimaki@...il.com>

Reviewed-by: Luca Weiss <luca@...tu.xyz>

> ---
> Changes in v2:
>   - Always enable IMEM node
>   - Move reboot-mode magic numbers to platform,
>     those should be always the same
> ---
>  arch/arm/boot/dts/qcom-msm8226.dtsi | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/qcom-msm8226.dtsi
> b/arch/arm/boot/dts/qcom-msm8226.dtsi index 8644540f5aae..284b7c666fea
> 100644
> --- a/arch/arm/boot/dts/qcom-msm8226.dtsi
> +++ b/arch/arm/boot/dts/qcom-msm8226.dtsi
> @@ -641,6 +641,20 @@ smd-edge {
>  				label = "lpass";
>  			};
>  		};
> +
> +		sram@...05000 {
> +			compatible = "qcom,msm8226-imem", "syscon", 
"simple-mfd";
> +			reg = <0xfe805000 0x1000>;
> +
> +			reboot-mode {
> +				compatible = "syscon-reboot-mode";
> +				offset = <0x65c>;
> +
> +				mode-bootloader = <0x77665500>;
> +				mode-normal     = <0x77665501>;
> +				mode-recovery   = <0x77665502>;
> +			};
> +		};
>  	};
> 
>  	timer {