linux-kernel - Re: [PATCH] NFS: Prefer strscpy over strlcpy calls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADmuW3X1M_j2j=nsx2hM0YO1NeQsrOeb2Z1GOoMAOHCcPozF=A@mail.gmail.com>
Date:   Mon, 22 May 2023 12:19:36 -0400
From:   Azeem Shaikh <azeemshaikh38@...il.com>
To:     Kees Cook <keescook@...omium.org>
Cc:     Trond Myklebust <trond.myklebust@...merspace.com>,
        Anna Schumaker <anna@...nel.org>,
        linux-hardening@...r.kernel.org, linux-nfs@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] NFS: Prefer strscpy over strlcpy calls

> > ---
> > Note to reviewers: the one case where this patch would modify existing behavior
> > is when strlen(src)==destlen==0. Current behavior returns 0, with this patch it
> > would return -1.
> >
> > Not sure what the implication of this updated behavior would be,
> > so bringing it to your attention.
>
> I'm not sure either, but I would prefer non-terminated strings produce
> an error, which this change does. :)
>
> Reviewed-by: Kees Cook <keescook@...omium.org>
>

Friendly ping.