linux-kernel - Re: [PATCH] cpufreq: intel_pstate: Avoid initializing variables prematurely

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0guY16bicakMokQtp=_DGbBb4hk6B=RuPp_8+bd0jt+6w@mail.gmail.com>
Date:   Mon, 22 May 2023 18:50:54 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Fieah Lim <kweifat@...il.com>
Cc:     srinivas.pandruvada@...ux.intel.com, lenb@...nel.org,
        rafael@...nel.org, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cpufreq: intel_pstate: Avoid initializing variables prematurely

On Sat, May 20, 2023 at 3:32 PM Fieah Lim <kweifat@...il.com> wrote:
>
> all_cpu_data struct is pretty large,

all_cpu_data is not a structure, it is an array of pointers.

If you want to clean up the code, please make sure that your cleanups
really make sense.

Also please don't make unrelated changes in one patch, this doesn't help much.

Thanks!