linux-kernel - Re: [PATCH v6 04/20] modpost: remove unused argument from secref

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKwvOdkKedXoVoRB6Jts0vunyRHsruL0_VmPn6CYJwNiiu38Dg@mail.gmail.com>
Date:   Mon, 22 May 2023 11:10:45 -0700
From:   Nick Desaulniers <ndesaulniers@...gle.com>
To:     Masahiro Yamada <masahiroy@...nel.org>
Cc:     linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
        Nathan Chancellor <nathan@...nel.org>,
        Nicolas Schier <nicolas@...sle.eu>
Subject: Re: [PATCH v6 04/20] modpost: remove unused argument from secref_whitelist()

On Sun, May 21, 2023 at 9:05 AM Masahiro Yamada <masahiroy@...nel.org> wrote:
>
> secref_whitelist() does not use the argument 'mismatch'.

Thanks for the patch!
Reviewed-by: Nick Desaulniers <ndesaulniers@...gle.com>

>
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
> ---
>
>  scripts/mod/modpost.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
> index ed2301e951a9..d2329ac32177 100644
> --- a/scripts/mod/modpost.c
> +++ b/scripts/mod/modpost.c
> @@ -1035,8 +1035,7 @@ static const struct sectioncheck *section_mismatch(
>   *   refsymname = *.constprop.*
>   *
>   **/
> -static int secref_whitelist(const struct sectioncheck *mismatch,
> -                           const char *fromsec, const char *fromsym,
> +static int secref_whitelist(const char *fromsec, const char *fromsym,
>                             const char *tosec, const char *tosym)
>  {
>         /* Check for pattern 1 */
> @@ -1206,7 +1205,7 @@ static void default_mismatch_handler(const char *modname, struct elf_info *elf,
>         tosym = sym_name(elf, to);
>
>         /* check whitelist - we may ignore it */
> -       if (!secref_whitelist(mismatch, fromsec, fromsym, tosec, tosym))
> +       if (!secref_whitelist(fromsec, fromsym, tosec, tosym))
>                 return;
>
>         sec_mismatch_count++;
> --
> 2.39.2
>


-- 
Thanks,
~Nick Desaulniers