linux-kernel - Re: [PATCH v4 2/2] leds: add aw20xx driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Ve4EAAj+6VTtYPS-5n+RSobN6ZcwS61kHFaGzHQ-8YhYw@mail.gmail.com>
Date:   Mon, 22 May 2023 21:52:58 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Lee Jones <lee@...nel.org>
Cc:     Martin Kurbanov <mmkurbanov@...rdevices.ru>,
        Pavel Machek <pavel@....cz>, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-kernel@...r.kernel.org, linux-leds@...r.kernel.org,
        devicetree@...r.kernel.org, kernel@...rdevices.ru
Subject: Re: [PATCH v4 2/2] leds: add aw20xx driver

On Mon, May 22, 2023 at 7:35 PM Lee Jones <lee@...nel.org> wrote:
> On Mon, 22 May 2023, Andy Shevchenko wrote:
> > On Mon, May 22, 2023 at 10:14 AM Lee Jones <lee@...nel.org> wrote:
> > > On Thu, 18 May 2023, Andy Shevchenko wrote:
> > > > On Wed, May 17, 2023 at 10:52 PM Martin Kurbanov
> > > > <mmkurbanov@...rdevices.ru> wrote:

...

> > > > I would do
> > > >
> > > >   i = 0;
> > > >
> > > > here and drop the assignment in the definition block to be more robust
> > >
> > > "here" where?
> >
> > > You've removed all context.
> >
> > That's not true. The below line exclusively defines the location in
> > the code that I'm talking about. Note, Martin understood that AFAICT
> > and addressed in the new version.
>
> I'd expect the author to have a solid understanding of the code.  I
> found this difficult to read as-was and had to go look at the patch to
> understand it.

I see your point.

> No biggy.  Just something to bear in mind.

No worries, and thanks for the remark. I'll try my best to satisfy
others and not only the author of the code in the future reviews.

> > > > against sudden reuse of i in between.
> > > >
> > > > > +       device_for_each_child_node(dev, child) {
> > > >
> > > > > +               i++;
> > > > > +       }


-- 
With Best Regards,
Andy Shevchenko