linux-kernel - Re: [PATCH] drivers: scsi: 3w-xxxx: Add error handling for initialization failure in `tw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq1mt1wnixx.fsf@ca-mkp.ca.oracle.com>
Date:   Mon, 22 May 2023 17:40:52 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Yuchen Yang <u202114568@...t.edu.cn>
Cc:     Adam Radford <aradford@...il.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        hust-os-kernel-patches@...glegroups.com,
        Dan Carpenter <dan.carpenter@...aro.org>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: scsi: 3w-xxxx: Add error handling for
 initialization failure in `tw_probe`


Yuchen,

> Smatch complains that:
> tw_probe() warn: missing error code 'retval'
>
> This patch adds error checking to `tw_probe` function to handle 
> initialization failure. If `tw_reset_sequence` function returns a 
> non-zero value, the function will return an `-EINVAL` error code 
> to indicate the initialization failure.
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Yuchen Yang <u202114568@...t.edu.cn>
> Reviewed-by: Dan Carpenter <dan.carpenter@...aro.org> 

Applied to 6.5/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering