linux-kernel - Re: [PATCH] sched: deadline: Remove unnecessary ‘NULL’ values from dl_task_offline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b5e6a3b7-aa72-1070-cb96-abf0a816884d@quicinc.com>
Date:   Mon, 22 May 2023 12:47:50 +0530
From:   Mukesh Ojha <quic_mojha@...cinc.com>
To:     Li zeming <zeming@...china.com>, <mingo@...hat.com>,
        <peterz@...radead.org>, <juri.lelli@...hat.com>,
        <vincent.guittot@...aro.org>, <dietmar.eggemann@....com>,
        <rostedt@...dmis.org>, <bsegall@...gle.com>, <mgorman@...e.de>,
        <bristot@...hat.com>, <vschneid@...hat.com>
CC:     <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sched: deadline: Remove unnecessary ‘NULL’ values from dl_task_offline_migration



On 5/24/2023 5:11 AM, Li zeming wrote:
> later_rq is assigned first, so it does not need to initialize the
> assignment.
> 
> Signed-off-by: Li zeming <zeming@...china.com>
> ---
>   kernel/sched/deadline.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> index 5a9a4b81c972..d823e608c7f0 100644
> --- a/kernel/sched/deadline.c
> +++ b/kernel/sched/deadline.c
> @@ -667,7 +667,7 @@ static struct rq *find_lock_later_rq(struct task_struct *task, struct rq *rq);
>   
>   static struct rq *dl_task_offline_migration(struct rq *rq, struct task_struct *p)
>   {
> -	struct rq *later_rq = NULL;
> +	struct rq *later_rq;
>   	struct dl_bw *dl_b;
>   
>   	later_rq = find_lock_later_rq(p, rq);

Acked-by: Mukesh Ojha <quic_mojha@...cinc.com>

-- Mukesh