linux-kernel - Re: [PATCH] sched/headers: remove duplicate included header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <512cf22a-1196-1191-cdbb-bda3a815999d@antgroup.com>
Date:   Mon, 22 May 2023 10:26:57 +0800
From:   "Yan Yan(cailing)" <yanyan.yan@...group.com>
To:     linux-kernel@...r.kernel.org, mingo@...hat.com
Cc:     "谈鉴锋" <henry.tjf@...group.com>,
        "Peter Zijlstra" <peterz@...radead.org>,
        "Juri Lelli" <juri.lelli@...hat.com>,
        "Vincent Guittot" <vincent.guittot@...aro.org>,
        "Dietmar Eggemann" <dietmar.eggemann@....com>,
        "Steven Rostedt" <rostedt@...dmis.org>,
        "Ben Segall" <bsegall@...gle.com>, "Mel Gorman" <mgorman@...e.de>,
        "Daniel Bristot de Oliveira" <bristot@...hat.com>,
        "Valentin Schneider" <vschneid@...hat.com>
Subject: Re: [PATCH] sched/headers: remove duplicate included header

Ping, any comments?

thanks,

-Yan Yan

在 2023/5/16 00:00, Yan Yan 写道:
> Ping.
>
> It seems that removing the two same included lines is ok. Because the 
> following "sched.h" also includes psi.h.
>
> Any comments?
>
> Thanks,
>
> -Yan Yan
>
> 在 2023/5/6 23:39, 晏艳(采苓) 写道:
>> linux/psi.h is included more than once.
>>
>> Signed-off-by: Yan Yan <yanyan.yan@...group.com>
>> ---
>>   kernel/sched/build_utility.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/kernel/sched/build_utility.c b/kernel/sched/build_utility.c
>> index 99bdd96f454f..80a3df49ab47 100644
>> --- a/kernel/sched/build_utility.c
>> +++ b/kernel/sched/build_utility.c
>> @@ -34,7 +34,6 @@
>>   #include <linux/nospec.h>
>>   #include <linux/proc_fs.h>
>>   #include <linux/psi.h>
>> -#include <linux/psi.h>
>>   #include <linux/ptrace_api.h>
>>   #include <linux/sched_clock.h>
>>   #include <linux/security.h>