linux-kernel - Re: [PATCH bpf-next] samples/bpf: hbm: Fix compile error about fallthrough marking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ceda1ef3-0bd2-9273-af59-81d896189ac5@iogearbox.net>
Date:   Mon, 22 May 2023 10:47:28 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Rong Tao <rtoax@...mail.com>, ast@...nel.org
Cc:     Rong Tao <rongtao@...tc.cn>, Andrii Nakryiko <andrii@...nel.org>,
        Martin KaFai Lau <martin.lau@...ux.dev>,
        Song Liu <song@...nel.org>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>,
        Stanislav Fomichev <sdf@...gle.com>,
        Hao Luo <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>,
        "open list:BPF [GENERAL] (Safe Dynamic Programs and Tools)" 
        <bpf@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH bpf-next] samples/bpf: hbm: Fix compile error about
 fallthrough marking

On 5/22/23 5:20 AM, Rong Tao wrote:
> From: Rong Tao <rongtao@...tc.cn>
> 
> commit f7a858bffcdd("tools: Rename __fallthrough to fallthrough") rename
> macro __fallthrough to fallthrough, commit 4b7ef71ac977("bpftool: Replace
> "__fallthrough" by a comment to address merge conflict") use comments to
> replace __fallthrough, here we can use fallthrough directly.
> 
> Compiling samples/bpf hits an error related to fallthrough marking:
>      ...
>      CC  samples/bpf/hbm.o
>      linux/samples/bpf/hbm.c: In function ‘main’:
>      linux/samples/bpf/hbm.c:501:25: error: ‘__fallthrough’ undeclared
>      (first use in this function); did you mean ‘fallthrough’?
>      501 |                         __fallthrough;
>          |                         ^~~~~~~~~~~~~
>          |                         fallthrough
> 
> Signed-off-by: Rong Tao <rongtao@...tc.cn>
> ---
>   samples/bpf/hbm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Fixed here already:

https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git/commit/?id=a820ca1a739b7e3ee0ddb48bdfa3c09dc7cd4302