linux-kernel - Re: [PATCH 3/3] ARM: dts: at91: Return to boolean properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8241a7ed-6c02-df96-fdcf-39339f50a6e0@microchip.com>
Date:   Mon, 22 May 2023 11:22:02 +0200
From:   Nicolas Ferre <nicolas.ferre@...rochip.com>
To:     <Ryan.Wanner@...rochip.com>, <robh+dt@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>,
        <alexandre.belloni@...tlin.com>, <claudiu.beznea@...rochip.com>,
        <linus.walleij@...aro.org>, <ludovic.desroches@...rochip.com>
CC:     <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH 3/3] ARM: dts: at91: Return to boolean properties

On 17/05/2023 at 13:54, Ryan.Wanner@...rochip.com wrote:
> From: Ryan Wanner <Ryan.Wanner@...rochip.com>
> 
> Returning back to commit 0dc23d1a8e17
> ("arm: dts: at91: Fix boolean properties with values") as pinctrl driver no
> longer expects an integer value and expects a simple boolean property.
> 
> Signed-off-by: Ryan Wanner <Ryan.Wanner@...rochip.com>

Okay:
Acked-by: Nicolas Ferre <nicolas.ferre@...rochip.com>

Thanks for fixing this as well. Best regards,
   Nicolas

> ---
>   arch/arm/boot/dts/at91-kizbox3-hs.dts      | 2 +-
>   arch/arm/boot/dts/at91-kizbox3_common.dtsi | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/at91-kizbox3-hs.dts b/arch/arm/boot/dts/at91-kizbox3-hs.dts
> index 7075df6549e9..fec7269088d1 100644
> --- a/arch/arm/boot/dts/at91-kizbox3-hs.dts
> +++ b/arch/arm/boot/dts/at91-kizbox3-hs.dts
> @@ -225,7 +225,7 @@ pinctrl_pio_zbe_rst: gpio_zbe_rst {
>   		pinctrl_pio_io_reset: gpio_io_reset {
>   			pinmux = <PIN_PB30__GPIO>;
>   			bias-disable;
> -			drive-open-drain = <1>;
> +			drive-open-drain;
>   			output-low;
>   		};
>   		pinctrl_pio_input: gpio_input {
> diff --git a/arch/arm/boot/dts/at91-kizbox3_common.dtsi b/arch/arm/boot/dts/at91-kizbox3_common.dtsi
> index abe27adfa4d6..465664628419 100644
> --- a/arch/arm/boot/dts/at91-kizbox3_common.dtsi
> +++ b/arch/arm/boot/dts/at91-kizbox3_common.dtsi
> @@ -211,7 +211,7 @@ pinctrl_flx4_default: flx4_i2c6_default {
>   		pinmux = <PIN_PD12__FLEXCOM4_IO0>, //DATA
>   		<PIN_PD13__FLEXCOM4_IO1>; //CLK
>   		bias-disable;
> -		drive-open-drain = <1>;
> +		drive-open-drain;
>   	};
>   
>   	pinctrl_pwm0 {

-- 
Nicolas Ferre