linux-kernel - Re: [PATCH v2 0/2] SPDX conversion from UDF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230522095308.ypwi5txynkbvnfw7@quack3>
Date:   Mon, 22 May 2023 11:53:08 +0200
From:   Jan Kara <jack@...e.cz>
To:     Bagas Sanjaya <bagasdotme@...il.com>
Cc:     Linux SPDX Licenses <linux-spdx@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Actions <linux-actions@...ts.infradead.org>,
        Linux Memory Management List <linux-mm@...ck.org>,
        Jan Kara <jack@...e.com>,
        Andreas Färber <afaerber@...e.de>,
        Manivannan Sadhasivam <mani@...nel.org>,
        Christoph Hellwig <hch@...radead.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Diederik de Haas <didi.debian@...ow.org>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH v2 0/2] SPDX conversion from UDF

On Mon 22-05-23 07:54:33, Bagas Sanjaya wrote:
> This small SPDX conversion series targets UDF file system, which is
> splitted from v2 of my SPDX conversion series that is triggered by
> Didi's GPL full name fixes [1]. It is done to ease review.
> 
> All boilerplates in fs/udf/ is converted, except fs/udf/ecma_167.h.
> The latter file apparently looks like 2-clause BSD Source-Code
> license, yet the second clause is from third clause of 3-Clause BSD.
> This custom license can't be expressed satisfiably in SPDX license
> identifier, hence the file doesn't get converted.
> 
> This series is based on mm-nonmm-unstable branch.
> 
> Changes since v1 [2]:
>   * Correct SPDX tag for LGPL (correct spdxcheck warning)
> 
> [1]: https://lore.kernel.org/linux-spdx/20230512100620.36807-1-bagasdotme@gmail.com/
> [2]: https://lore.kernel.org/linux-mm/20230517083344.1090863-1-bagasdotme@gmail.com/
> 
> Bagas Sanjaya (2):
>   fs: udf: Replace GPL 2.0 boilerplate license notice with SPDX
>     identifier
>   fs: udf: udftime: Replace LGPL boilerplate with SPDX identifier

The patches look good to me. So unless someone objects in a few days, I'll
queue them into my tree. Thanks!

								Honza

> 
>  fs/udf/balloc.c    |  6 +-----
>  fs/udf/dir.c       |  6 +-----
>  fs/udf/directory.c |  6 +-----
>  fs/udf/file.c      |  6 +-----
>  fs/udf/ialloc.c    |  6 +-----
>  fs/udf/inode.c     |  6 +-----
>  fs/udf/lowlevel.c  |  6 +-----
>  fs/udf/misc.c      |  6 +-----
>  fs/udf/namei.c     |  6 +-----
>  fs/udf/partition.c |  6 +-----
>  fs/udf/super.c     |  6 +-----
>  fs/udf/symlink.c   |  6 +-----
>  fs/udf/truncate.c  |  6 +-----
>  fs/udf/udftime.c   | 18 ++----------------
>  fs/udf/unicode.c   |  6 +-----
>  15 files changed, 16 insertions(+), 86 deletions(-)
> 
> 
> base-commit: 7e61b33831bc7680b24bc04af9ed9c1553dac406
> 
> Range-diff against v1:
> 
> 1:  442194d17ed043 = 1:  30fb64a215be1c fs: udf: Replace GPL 2.0 boilerplate license notice with SPDX identifier
> 2:  ccb407446ab324 ! 2:  f7cfeaa5cec879 fs: udf: udftime: Replace LGPL boilerplate with SPDX identifier
>     @@ Commit message
>      
>       ## fs/udf/udftime.c ##
>      @@
>     -+// SPDX-License-Identifier: LGPL-2.0-or-later
>     ++// SPDX-License-Identifier: LGPL-2.0+
>       /* Copyright (C) 1993, 1994, 1995, 1996, 1997 Free Software Foundation, Inc.
>          This file is part of the GNU C Library.
>      -   Contributed by Paul Eggert (eggert@...nsun.com).
> 
> -- 
> An old man doll... just what I always wanted! - Clara
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR