linux-kernel - Re: [PATCH mm-unstable 1/4] mm: multi-gen LRU: use macro for bitmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d7d8d50b-ac3c-56e8-ca3b-5248c8855102@redhat.com>
Date:   Mon, 22 May 2023 13:33:33 +0200
From:   David Hildenbrand <david@...hat.com>
To:     "T.J. Alumbaugh" <talumbau@...gle.com>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     Yuanchu Xie <yuanchu@...gle.com>, Yu Zhao <yuzhao@...gle.com>,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        linux-mm@...gle.com
Subject: Re: [PATCH mm-unstable 1/4] mm: multi-gen LRU: use macro for bitmap

On 22.05.23 13:20, T.J. Alumbaugh wrote:
> Use DECLARE_BITMAP macro when possible.
> 
> Signed-off-by: T.J. Alumbaugh <talumbau@...gle.com>
> ---
>   mm/vmscan.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 4637f6462e9c..cf18873a36b9 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -4144,7 +4144,7 @@ static void walk_pmd_range(pud_t *pud, unsigned long start, unsigned long end,
>   	unsigned long next;
>   	unsigned long addr;
>   	struct vm_area_struct *vma;
> -	unsigned long bitmap[BITS_TO_LONGS(MIN_LRU_BATCH)];
> +	DECLARE_BITMAP(bitmap, MIN_LRU_BATCH);
>   	unsigned long first = -1;
>   	struct lru_gen_mm_walk *walk = args->private;
>   

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 
Thanks,

David / dhildenb