linux-kernel - Re: [PATCH v5 09/44] drm: handle HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <5dcf01e7-4378-4b4c-9751-454b16270c69@app.fastmail.com>
Date:   Mon, 22 May 2023 15:06:37 +0200
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Thomas Zimmermann" <tzimmermann@...e.de>,
        "Niklas Schnelle" <schnelle@...ux.ibm.com>,
        "Dave Airlie" <airlied@...hat.com>,
        "Gerd Hoffmann" <kraxel@...hat.com>,
        "Dave Airlie" <airlied@...il.com>,
        "Daniel Vetter" <daniel@...ll.ch>
Cc:     Linux-Arch <linux-arch@...r.kernel.org>,
        "Arnd Bergmann" <arnd@...nel.org>,
        "Albert Ou" <aou@...s.berkeley.edu>,
        "Rafael J . Wysocki" <rafael@...nel.org>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
        "Paul Walmsley" <paul.walmsley@...ive.com>,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org,
        virtualization@...ts.linux-foundation.org,
        "Alan Stern" <stern@...land.harvard.edu>,
        spice-devel@...ts.freedesktop.org,
        Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
        "Bjorn Helgaas" <bhelgaas@...gle.com>,
        "Geert Uytterhoeven" <geert@...ux-m68k.org>,
        "Mauro Carvalho Chehab" <mchehab@...nel.org>,
        "Palmer Dabbelt" <palmer@...belt.com>
Subject: Re: [PATCH v5 09/44] drm: handle HAS_IOPORT dependencies

On Mon, May 22, 2023, at 14:38, Thomas Zimmermann wrote:
> Am 22.05.23 um 12:50 schrieb Niklas Schnelle:

>> There is also a direct and hard coded use in cirrus.c which according to
>> the comment is only necessary during resume.  Let's just skip this as
>> for example s390 which doesn't have I/O port support also doesen't
>> support suspend/resume.
>
> I think we should consider making cirrus depend on HAS_IOPORT. The 
> driver is only for qemu's cirrus emulation, which IIRC can only be 
> enabled for i586. And it has all been deprecated long ago.

I tried it out in arm64 debvm, and both the kernel and Xorg drivers
are detected just fine according to the log. I only get a black
screen, which could be the result of a missing VGA BIOS or the missing
unblank Port I/O in the driver (I doubt the VGA ports are hooked up
on arm64 qemu), but there is a good chance that it's currently
working for someone else.

      Arnd