linux-kernel - Re: [PATCH] drm/amd/display: avoid calling missing .resync_fifo_dccg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <63817b59-90f7-9881-fb69-42da00ccaeed@amd.com>
Date:   Tue, 23 May 2023 10:37:00 -0400
From:   Hamza Mahfooz <hamza.mahfooz@....com>
To:     Arnd Bergmann <arnd@...nel.org>,
        Harry Wentland <harry.wentland@....com>,
        Leo Li <sunpeng.li@....com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@....com>,
        Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        "Pan, Xinhui" <Xinhui.Pan@....com>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>,
        Tom Chung <chiahsuan.chung@....com>,
        Nicholas Kazlauskas <nicholas.kazlauskas@....com>,
        Saaem Rizvi <syedsaaem.rizvi@....com>
Cc:     Charlene Liu <Charlene.Liu@....com>,
        Jingwen Zhu <Jingwen.Zhu@....com>,
        Arnd Bergmann <arnd@...db.de>,
        "Nagulendran, Iswara" <Iswara.Nagulendran@....com>,
        dri-devel@...ts.freedesktop.org, Wenjing Liu <wenjing.liu@....com>,
        linux-kernel@...r.kernel.org, amd-gfx@...ts.freedesktop.org,
        Alvin Lee <Alvin.Lee2@....com>, Jun Lei <Jun.Lei@....com>,
        Mario Limonciello <mario.limonciello@....com>
Subject: Re: [PATCH] drm/amd/display: avoid calling missing
 .resync_fifo_dccg_dio()

On 5/23/23 04:34, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> The .resync_fifo_dccg_dio() callback pointer was added in an #ifdef block,
> but is called unconditionally:
> 
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:2292:31: error: 'struct hwseq_private_funcs' has no member named 'resync_fifo_dccg_dio'
> 
> Add the same #ifdef around the caller as well.
> 
> Fixes: 6354b0dc3a7a ("drm/amd/display: Trigger DIO FIFO resync on commit streams")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied, thanks!

> ---
>   drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
> index c6fe2c00aedb..d4cacb8df631 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
> @@ -2289,8 +2289,10 @@ enum dc_status dce110_apply_ctx_to_hw(
>   		if (DC_OK != status)
>   			return status;
>   
> +#ifdef CONFIG_DRM_AMD_DC_FP
>   		if (hws->funcs.resync_fifo_dccg_dio)
>   			hws->funcs.resync_fifo_dccg_dio(hws, dc, context);
> +#endif
>   	}
>   
>   	if (dc->fbc_compressor)
-- 
Hamza