linux-kernel - Re: [PATCH] scsi: 3w-9xxx: Replace all non-returning strlcpy with strscpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <A8157E92-E340-4031-8054-378728CC5BD4@kernel.org>
Date:   Mon, 22 May 2023 18:21:02 -0700
From:   Kees Cook <kees@...nel.org>
To:     "Martin K. Petersen" <martin.petersen@...cle.com>,
        Kees Cook <keescook@...omium.org>
CC:     azeemshaikh38@...il.com, Adam Radford <aradford@...il.com>,
        martin.petersen@...cle.com, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org, jejb@...ux.ibm.com,
        linux-hardening@...r.kernel.org
Subject: Re: [PATCH] scsi: 3w-9xxx: Replace all non-returning strlcpy with strscpy

On May 22, 2023 3:41:58 PM PDT, "Martin K. Petersen" <martin.petersen@...cle.com> wrote:
>
>Kees,
>
>> On Wed, 17 May 2023 14:29:55 +0000, Azeem Shaikh wrote:
>>> strlcpy() reads the entire source buffer first.
>>> This read may exceed the destination size limit.
>>> This is both inefficient and can lead to linear read
>>> overflows if a source string is not NUL-terminated [1].
>>> In an effort to remove strlcpy() completely [2], replace
>>> strlcpy() here with strscpy().
>>> No return values were used, so direct replacement is safe.
>>> 
>>> [...]
>>
>> Applied to for-next/hardening, thanks!
>>
>> [1/1] scsi: 3w-9xxx: Replace all non-returning strlcpy with strscpy
>>       https://git.kernel.org/kees/c/fa36c95739ab
>
>Are you planning on sending these? That's fine with me, just need to
>know if I should close them in patchwork...

Yeah, I took a bunch that hadn't been picked up yet:
https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git/log/?h=for-next/hardening

Thanks!


-- 
Kees Cook