linux-kernel - Re: [PATCH] regulator: core: Streamline debugfs operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2c26f143-47ae-4c2f-bd55-2e3b7a6300f0@sirena.org.uk>
Date:   Tue, 23 May 2023 16:16:11 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Geert Uytterhoeven <geert+renesas@...der.be>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Osama Muhammad <osmtendev@...il.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regulator: core: Streamline debugfs operations

On Tue, May 23, 2023 at 05:03:58PM +0200, Geert Uytterhoeven wrote:

> -	if (!regulator->debugfs) {
> +	if (IS_ERR(regulator->debugfs))
>  		rdev_dbg(rdev, "Failed to create debugfs directory\n");
> -	} else {
> -		debugfs_create_u32("uA_load", 0444, regulator->debugfs,
> -				   &regulator->uA_load);
> -	}
> +
> +	debugfs_create_u32("uA_load", 0444, regulator->debugfs,
> +			   &regulator->uA_load);

No, it's actually useful to not just dump these files in the root
directory if we fail to create the per regulator directory.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)