linux-kernel - Re: [PATCH] bus: mhi: host: Add userspace character interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 23 May 2023 09:27:19 +0800
From:   kernel test robot <lkp@...el.com>
To:     Jeffrey Hugo <quic_jhugo@...cinc.com>, mani@...nel.org,
        gregkh@...uxfoundation.org
Cc:     oe-kbuild-all@...ts.linux.dev, andersson@...nel.org,
        daniel@...ll.ch, mhi@...ts.linux.dev,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        Pranjal Ramajor Asha Kanojiya <quic_pkanojiy@...cinc.com>,
        Jeffrey Hugo <quic_jhugo@...cinc.com>
Subject: Re: [PATCH] bus: mhi: host: Add userspace character interface

Hi Jeffrey,

kernel test robot noticed the following build warnings:

[auto build test WARNING on char-misc/char-misc-testing]
[also build test WARNING on char-misc/char-misc-next char-misc/char-misc-linus staging/staging-testing staging/staging-next staging/staging-linus usb/usb-testing usb/usb-next usb/usb-linus linus/master v6.4-rc3 next-20230522]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Jeffrey-Hugo/bus-mhi-host-Add-userspace-character-interface/20230523-030635
base:   char-misc/char-misc-testing
patch link:    https://lore.kernel.org/r/20230522190459.13790-1-quic_jhugo%40quicinc.com
patch subject: [PATCH] bus: mhi: host: Add userspace character interface
config: alpha-allyesconfig
compiler: alpha-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/cee82d13b1e1f8848987450606a67e913b78bf86
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Jeffrey-Hugo/bus-mhi-host-Add-userspace-character-interface/20230523-030635
        git checkout cee82d13b1e1f8848987450606a67e913b78bf86
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=alpha olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=alpha SHELL=/bin/bash drivers/bus/mhi/host/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202305230802.sYajq6Nz-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/bus/mhi/host/uci.c:532:5: warning: no previous prototype for 'mhi_uci_init' [-Wmissing-prototypes]
     532 | int mhi_uci_init(void)
         |     ^~~~~~~~~~~~
>> drivers/bus/mhi/host/uci.c:560:6: warning: no previous prototype for 'mhi_uci_exit' [-Wmissing-prototypes]
     560 | void mhi_uci_exit(void)
         |      ^~~~~~~~~~~~


vim +/mhi_uci_init +532 drivers/bus/mhi/host/uci.c

   531	
 > 532	int mhi_uci_init(void)
   533	{
   534		int ret;
   535	
   536		ret = register_chrdev(0, MHI_UCI_DRIVER_NAME, &mhidev_fops);
   537		if (ret < 0)
   538			return ret;
   539	
   540		uci_dev_major = ret;
   541		uci_dev_class = class_create(MHI_UCI_DRIVER_NAME);
   542		if (IS_ERR(uci_dev_class)) {
   543			ret = PTR_ERR(uci_dev_class);
   544			goto unregister_chrdev;
   545		}
   546	
   547		ret = mhi_driver_register(&mhi_uci_driver);
   548		if (ret)
   549			goto destroy_class;
   550	
   551		return 0;
   552	
   553	destroy_class:
   554		class_destroy(uci_dev_class);
   555	unregister_chrdev:
   556		unregister_chrdev(uci_dev_major, MHI_UCI_DRIVER_NAME);
   557		return ret;
   558	}
   559	
 > 560	void mhi_uci_exit(void)

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

View attachment "config" of type "text/plain" (321801 bytes)