linux-kernel - Re: [PATCH] arm64: Only HAVE_HARDLOCKUP_DETECTOR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <d651c1f2-ce77-4876-bbc4-88e014a83f35@app.fastmail.com>
Date:   Tue, 23 May 2023 17:52:24 +0200
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Doug Anderson" <dianders@...omium.org>,
        "Andrew Morton" <akpm@...ux-foundation.org>
Cc:     "Catalin Marinas" <catalin.marinas@....com>,
        "Lecopzer Chen" <lecopzer.chen@...iatek.com>,
        "Pingfan Liu" <kernelfans@...il.com>,
        "Sumit Garg" <sumit.garg@...aro.org>,
        "Will Deacon" <will@...nel.org>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: Only HAVE_HARDLOCKUP_DETECTOR_PERF if the PMU config is
 enabled

On Tue, May 23, 2023, at 16:39, Douglas Anderson wrote:
> If you try to enable the arm64 perf-based hardlockup detector but you
> don't enable CONFIG_ARM_PMU then you'll get an error:
>
> arch/arm64/kernel/watchdog_hld.c: In function 
> 'arch_perf_nmi_is_available':
> arch/arm64/kernel/watchdog_hld.c:35:16: error: implicit declaration of 
> function 'arm_pmu_irq_is_nmi' [-Werror=implicit-function-declaration]
>    35 |         return arm_pmu_irq_is_nmi();
>
> It doesn't make sense to enable HAVE_HARDLOCKUP_DETECTOR_PERF if the
> PMU isn't enabled. Let's add a dependency. HW_PERF_EVENTS is a synonum
> for ARM_PMU and makes the most logical sense here, so add the
> dependency on that.
>
> Reported-by: Arnd Bergmann <arnd@...db.de>
> Closes: https://lore.kernel.org/r/20230522114922.1052421-1-arnd@kernel.org
> Fixes: 02ea35ee19d9 ("arm64: enable perf events based hard lockup detector")
> Signed-off-by: Douglas Anderson <dianders@...omium.org>

Acked-by: Arnd Bergmann <arnd@...db.de>

Still build testing it with randconfigs, but I assume it's fine.

    Arnd