linux-kernel - Re: [PATCH 6.3 000/364] 6.3.4-rc1 review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2023052357-deepen-celery-bdd5@gregkh>
Date:   Tue, 23 May 2023 17:51:10 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Chris Paterson <Chris.Paterson2@...esas.com>
Cc:     "stable@...r.kernel.org" <stable@...r.kernel.org>,
        "patches@...ts.linux.dev" <patches@...ts.linux.dev>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "torvalds@...ux-foundation.org" <torvalds@...ux-foundation.org>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "linux@...ck-us.net" <linux@...ck-us.net>,
        "shuah@...nel.org" <shuah@...nel.org>,
        "patches@...nelci.org" <patches@...nelci.org>,
        "lkft-triage@...ts.linaro.org" <lkft-triage@...ts.linaro.org>,
        "pavel@...x.de" <pavel@...x.de>,
        "jonathanh@...dia.com" <jonathanh@...dia.com>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "sudipm.mukherjee@...il.com" <sudipm.mukherjee@...il.com>,
        "srw@...dewatkins.net" <srw@...dewatkins.net>,
        "rwarsow@....de" <rwarsow@....de>
Subject: Re: [PATCH 6.3 000/364] 6.3.4-rc1 review

On Mon, May 22, 2023 at 08:29:05PM +0000, Chris Paterson wrote:
> Hello Greg,
> 
> > From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > Sent: Monday, May 22, 2023 8:05 PM
> > 
> > This is the start of the stable review cycle for the 6.3.4 release.
> > There are 364 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> > 
> > Responses should be made by Wed, 24 May 2023 19:03:25 +0000.
> > Anything received after that time might be too late.
> 
> I'm seeing a few build failures with Linux 6.3.4-rc1 (20efcce0526d) due to the drivers/usb/host/xhci.c driver:
> 
> drivers/usb/host/xhci.c:497:19: error: static declaration of 'xhci_try_enable_msi' follows non-static declaration
>   497 | static inline int xhci_try_enable_msi(struct usb_hcd *hcd)
>       |                   ^~~~~~~~~~~~~~~~~~~
> In file included from drivers/usb/host/xhci.c:22:
> drivers/usb/host/xhci.h:2146:5: note: previous declaration of 'xhci_try_enable_msi' was here
>  2146 | int xhci_try_enable_msi(struct usb_hcd *hcd);
>       |     ^~~~~~~~~~~~~~~~~~~
> 
> Example build failure: https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/jobs/4328533790#L2178
> Pipeline: https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/pipelines/875108293
> 
> Commit 78887e3e5f00 ("xhci: Avoid PCI MSI/MSIX interrupt reinitialization at resume") adds the offending code.
> I'm only seeing this for the 6.3 rc.

Thanks, I've dropped the offending change and will push out a -rc2.

greg k-h