linux-kernel - Re: [PATCH] drm/bridge: dw-hdmi: Replace all non-returning strlcpy with strscpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <168486250045.3617730.17499429425987433532.b4-ty@kernel.org>
Date:   Tue, 23 May 2023 19:21:49 +0200
From:   rfoss@...nel.org
To:     Andrzej Hajda <andrzej.hajda@...el.com>,
        Azeem Shaikh <azeemshaikh38@...il.com>,
        Neil Armstrong <neil.armstrong@...aro.org>
Cc:     Robert Foss <rfoss@...nel.org>, linux-kernel@...r.kernel.org,
        Jonas Karlman <jonas@...boo.se>,
        Ville Syrjälä 
        <ville.syrjala@...ux.intel.com>, Daniel Vetter <daniel@...ll.ch>,
        Guillaume BRUN <the.cheaterman@...il.com>,
        linux-hardening@...r.kernel.org,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Lucas Stach <l.stach@...gutronix.de>,
        David Airlie <airlied@...il.com>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        Maxime Ripard <maxime@...no.tech>,
        dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] drm/bridge: dw-hdmi: Replace all non-returning strlcpy with strscpy

From: Robert Foss <rfoss@...nel.org>

On Mon, 22 May 2023 15:52:10 +0000, Azeem Shaikh wrote:
> strlcpy() reads the entire source buffer first.
> This read may exceed the destination size limit.
> This is both inefficient and can lead to linear read
> overflows if a source string is not NUL-terminated [1].
> In an effort to remove strlcpy() completely [2], replace
> strlcpy() here with strscpy().
> No return values were used, so direct replacement is safe.
> 
> [...]

Applied, thanks!

[1/1] drm/bridge: dw-hdmi: Replace all non-returning strlcpy with strscpy
      https://cgit.freedesktop.org/drm/drm-misc/commit/?id=37cee4876a45



Rob