linux-kernel - Re: [PATCH 2/2] drm/panel-fannal-c3004: Add fannal c3004 DSI panel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkda8Q+zy-J9Hs28eJuioaE6eEzDmFE6ftEGgs9ot0t4Y6g@mail.gmail.com>
Date:   Tue, 23 May 2023 19:33:37 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Paulo Pavacic <pavacic.p@...il.com>
Cc:     neil.armstrong@...aro.org, sam@...nborg.org, airlied@...il.com,
        daniel@...ll.ch, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH 2/2] drm/panel-fannal-c3004: Add fannal c3004 DSI panel

On Fri, May 19, 2023 at 4:25 PM Paulo Pavacic <pavacic.p@...il.com> wrote:

> +//macro for writing to DSI
> +#define WRITE_DSI(dsi, seq...)                                                   \
> +       {                                                                        \
> +               const u8 d[] = { seq };                                          \
> +               int ret = mipi_dsi_generic_write(dsi, d, ARRAY_SIZE(d));         \
> +               if (ret < 0) {                                                   \
> +                       dev_err(&dsi->dev,                                       \
> +                               "Error (%d) occurred while trying to"            \
> +                               " write MIPI DSI command: %s (decimal value)\n", \
> +                               ret, d);                                         \
> +               }                                                                \
> +       }

As said for the other patch, this reinvents mipi_dsi_dcs_write_seq()
so use that instead.

mipi_dsi_dcs_write_seq(dsi, 0xFF, 0x77, 0x01, 0x00, 0x00, 0x13);
etc.

Yours,
Linus Walleij