linux-kernel - Re: [PATCH -next] cgroup: Remove out-of-date comment in cgroup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZG0PYH7a9Mw50bEl@slm.duckdns.org>
Date:   Tue, 23 May 2023 09:09:20 -1000
From:   Tejun Heo <tj@...nel.org>
To:     Xiu Jianfeng <xiujianfeng@...weicloud.com>
Cc:     lizefan.x@...edance.com, hannes@...xchg.org,
        cgroups@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] cgroup: Remove out-of-date comment in
 cgroup_migrate()

On Tue, May 23, 2023 at 07:14:56PM +0800, Xiu Jianfeng wrote:
> From: Xiu Jianfeng <xiujianfeng@...wei.com>
> 
> Commit 674b745e22b3 ("cgroup: remove rcu_read_lock()/rcu_read_unlock()
> in critical section of spin_lock_irq()") has removed the rcu_read_lock,
> which makes the comment out-of-date, so remove it.
> 
> Signed-off-by: Xiu Jianfeng <xiujianfeng@...wei.com>

So, that removed rcu_read_lock() because it's implied by the irq disable but
the comment content is still useful in describing what's preventing
use-after-free. Can you please update the comment accordingly instead?

Thanks.

-- 
tejun