linux-kernel - RE: [PATCH v6 0/6] Support TDX guests on Hyper-V

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SA1PR21MB133594566A3337BEF253F2F2BF40A@SA1PR21MB1335.namprd21.prod.outlook.com>
Date:   Tue, 23 May 2023 19:24:14 +0000
From:   Dexuan Cui <decui@...rosoft.com>
To:     Dave Hansen <dave.hansen@...el.com>,
        "ak@...ux.intel.com" <ak@...ux.intel.com>,
        "arnd@...db.de" <arnd@...db.de>, "bp@...en8.de" <bp@...en8.de>,
        "brijesh.singh@....com" <brijesh.singh@....com>,
        "dan.j.williams@...el.com" <dan.j.williams@...el.com>,
        "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        "hpa@...or.com" <hpa@...or.com>,
        "jane.chu@...cle.com" <jane.chu@...cle.com>,
        "kirill.shutemov@...ux.intel.com" <kirill.shutemov@...ux.intel.com>,
        KY Srinivasan <kys@...rosoft.com>,
        "linux-arch@...r.kernel.org" <linux-arch@...r.kernel.org>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "luto@...nel.org" <luto@...nel.org>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "rostedt@...dmis.org" <rostedt@...dmis.org>,
        "sathyanarayanan.kuppuswamy@...ux.intel.com" 
        <sathyanarayanan.kuppuswamy@...ux.intel.com>,
        "seanjc@...gle.com" <seanjc@...gle.com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "tony.luck@...el.com" <tony.luck@...el.com>,
        "wei.liu@...nel.org" <wei.liu@...nel.org>,
        "x86@...nel.org" <x86@...nel.org>,
        "Michael Kelley (LINUX)" <mikelley@...rosoft.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Tianyu Lan <Tianyu.Lan@...rosoft.com>
Subject: RE: [PATCH v6 0/6] Support TDX guests on Hyper-V

> From: Dexuan Cui <decui@...rosoft.com>
> Sent: Thursday, May 4, 2023 3:54 PM
> To: ak@...ux.intel.com; arnd@...db.de; bp@...en8.de;
> brijesh.singh@....com; dan.j.williams@...el.com;
> dave.hansen@...ux.intel.com; Haiyang Zhang <haiyangz@...rosoft.com>;
> hpa@...or.com; jane.chu@...cle.com; kirill.shutemov@...ux.intel.com; KY
> Srinivasan <kys@...rosoft.com>; linux-arch@...r.kernel.org;
> linux-hyperv@...r.kernel.org; luto@...nel.org; mingo@...hat.com;
> peterz@...radead.org; rostedt@...dmis.org;
> sathyanarayanan.kuppuswamy@...ux.intel.com; seanjc@...gle.com;
> tglx@...utronix.de; tony.luck@...el.com; wei.liu@...nel.org; x86@...nel.org;
> Michael Kelley (LINUX) <mikelley@...rosoft.com>
> Cc: linux-kernel@...r.kernel.org; Tianyu Lan <Tianyu.Lan@...rosoft.com>;
> Dexuan Cui <decui@...rosoft.com>
> Subject: [PATCH v6 0/6] Support TDX guests on Hyper-V
> 
> The patchset adds the Hyper-V specific code so that a TDX guest can run
> on Hyper-V. Please review.
> 
> The v6 patchset is based on today's mainline (a1fd058b07d5).
> 
> The v6 patchset addressed Michael's comments on patch 5:
>   Removed 2 unnecessary lines of messages from the commit log.
>   Fixed the error handling path for hv_synic_alloc()/free().
>   Printed the 'ret' in hv_synic_alloc()/free().
> 
> @Michael Kelley: Can you please review patch 5?

Thanks Michael for your Reviewed-by on patch 5.
 
> @x86 maintainers:
>   If the patches look good to you, can you please take patch 1 and 2
> into the tip tree?

Hi Dave and all, could you please take a look at the patchset?

The patchset can also be viewed here:
https://lwn.net/ml/linux-kernel/20230504225351.10765-1-decui%40microsoft.com/

> @Wei Liu: I think patch 3, 4, 5, 6 should go through the Hyper-V tree
> since they change the Hyper-V code.
> 
> If you want to view the patches on github, it is here:
> https://github.com/dcui/tdx/commits/decui/mainline/v6
> 
> FYI, v1-v5 are here:
>  <snipped> on 5/23/2023
>  
> Thanks,
> Dexuan
> 
> Dexuan Cui (6):
>   x86/tdx: Retry TDVMCALL_MAP_GPA() when needed
>   x86/tdx: Support vmalloc() for tdx_enc_status_changed()
>   x86/hyperv: Add hv_isolation_type_tdx() to detect TDX guests
>   x86/hyperv: Support hypercalls for TDX guests
>   Drivers: hv: vmbus: Support TDX guests
>   x86/hyperv: Fix serial console interrupts for TDX guests
> 
>  arch/x86/coco/tdx/tdx.c            | 122
> ++++++++++++++++++++++-------
>  arch/x86/hyperv/hv_apic.c          |   6 +-
>  arch/x86/hyperv/hv_init.c          |  27 ++++++-
>  arch/x86/hyperv/ivm.c              |  20 +++++
>  arch/x86/include/asm/hyperv-tlfs.h |   3 +-
>  arch/x86/include/asm/mshyperv.h    |  20 +++++
>  arch/x86/kernel/cpu/mshyperv.c     |  43 ++++++++++
>  drivers/hv/hv.c                    |  65 ++++++++++++++-
>  drivers/hv/hv_common.c             |  30 +++++++
>  include/asm-generic/mshyperv.h     |   1 +
>  10 files changed, 300 insertions(+), 37 deletions(-)

Thanks,
-- Dexuan