[<prev] [next>] [day] [month] [year] [list]
Message-ID: <f39da4b5-528b-e389-c0ee-d31add169620@mleia.com>
Date: Tue, 23 May 2023 23:17:37 +0300
From: Vladimir Zapolskiy <vz@...ia.com>
To: Arnd Bergmann <arnd@...nel.org>, soc@...nel.org
Cc: Arnd Bergmann <arnd@...db.de>,
Russell King <linux@...linux.org.uk>,
Bartosz Golaszewski <brgl@...ev.pl>,
Hartley Sweeten <hsweeten@...ionengravers.com>,
Alexander Sverdlin <alexander.sverdlin@...il.com>,
Andre Przywara <andre.przywara@....com>,
Shawn Guo <shawnguo@...nel.org>,
Sascha Hauer <s.hauer@...gutronix.de>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Fabio Estevam <festevam@...il.com>,
NXP Linux Team <linux-imx@....com>,
Aaro Koskinen <aaro.koskinen@....fi>,
Janusz Krzysztofik <jmkrzyszt@...il.com>,
Tony Lindgren <tony@...mide.com>, Andrew Lunn <andrew@...n.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
Gregory Clement <gregory.clement@...tlin.com>,
Daniel Mack <daniel@...que.org>,
Haojian Zhuang <haojian.zhuang@...il.com>,
Robert Jarzmik <robert.jarzmik@...e.fr>,
Viresh Kumar <vireshk@...nel.org>,
Shiraz Hashim <shiraz.linux.kernel@...il.com>,
Sudeep Holla <sudeep.holla@....com>,
Lorenzo Pieralisi <lpieralisi@...nel.org>,
Linus Walleij <linus.walleij@...aro.org>,
Michael Turquette <mturquette@...libre.com>,
Stephen Boyd <sboyd@...nel.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Alan Stern <stern@...land.harvard.edu>,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-omap@...r.kernel.org, linux-clk@...r.kernel.org,
linux-usb@...r.kernel.org
Subject: Re: [PATCH 06/13] ARM: lpc32xx: add missing include
On 5/16/23 18:31, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
>
> lpc32xx_loopback_set() is defined in linux/soc/nxp/lpc32xx-misc.h but
> this is not included before the function definition.
>
> arch/arm/mach-lpc32xx/serial.c:63:6: error: no previous prototype for 'lpc32xx_loopback_set'
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
> arch/arm/mach-lpc32xx/serial.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-lpc32xx/serial.c b/arch/arm/mach-lpc32xx/serial.c
> index 3e765c4bf986..3b1203db81b2 100644
> --- a/arch/arm/mach-lpc32xx/serial.c
> +++ b/arch/arm/mach-lpc32xx/serial.c
> @@ -15,6 +15,7 @@
> #include <linux/serial_8250.h>
> #include <linux/clk.h>
> #include <linux/io.h>
> +#include <linux/soc/nxp/lpc32xx-misc.h>
>
> #include "lpc32xx.h"
> #include "common.h"
Acked-by: Vladimir Zapolskiy <vz@...ia.com>
If you wish, you may consider to add one more tag:
Fixes: ffba29c9ebd0 ("serial: lpc32xx: allow compile testing")
--
Best wishes,
Vladimir
Powered by blists - more mailing lists