linux-kernel - Re: [PATCH] kernfs: fix missing kernfs_idr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <6D4D62D0-FD5D-4065-8D7F-C6E220186DE6@linux.dev>
Date:   Tue, 23 May 2023 10:17:04 +0800
From:   Muchun Song <muchun.song@...ux.dev>
To:     Tejun Heo <tj@...nel.org>
Cc:     Muchun Song <songmuchun@...edance.com>,
        Greg KH <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kernfs: fix missing kernfs_idr_lock to remove an ID from
 the IDR



> On May 23, 2023, at 03:08, Tejun Heo <tj@...nel.org> wrote:
> 
> On Tue, May 16, 2023 at 11:45:36AM +0800, Muchun Song wrote:
>> @@ -655,7 +660,7 @@ static struct kernfs_node *__kernfs_new_node(struct kernfs_root *root,
>> return kn;
>> 
>>  err_out3:
>> - idr_remove(&root->ino_idr, (u32)kernfs_ino(kn));
>> + kernfs_idr_remove(root, kn);
> 
> Good catch but I'd just open code the locking here.

OK. I'll send v2.

Thanks.

> 
> Thanks.
> 
> -- 
> tejun