linux-kernel - Re: [PATCH] mm-unstable: Multi-gen LRU: Fix workingset accounting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOUHufb88CBQibAx=jr7xX7y4Witw4HhCSAd-P4q2qoCKBLZSw@mail.gmail.com>
Date:   Tue, 23 May 2023 16:04:51 -0600
From:   Yu Zhao <yuzhao@...gle.com>
To:     Kalesh Singh <kaleshsingh@...gle.com>, akpm@...ux-foundation.org
Cc:     surenb@...gle.com, android-mm@...gle.com, kernel-team@...roid.com,
        Charan Teja Kalla <quic_charante@...cinc.com>,
        Oleksandr Natalenko <oleksandr@...alenko.name>,
        "Jan Alexander Steffens (heftig)" <heftig@...hlinux.org>,
        Brian Geffon <bgeffon@...gle.com>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm-unstable: Multi-gen LRU: Fix workingset accounting

On Tue, May 23, 2023 at 2:59 PM Kalesh Singh <kaleshsingh@...gle.com> wrote:
>
> On Android app cycle workloads, MGLRU showed a significant reduction
> in workingset refaults although pgpgin/pswpin remained relatively
> unchanged. This indicated MGLRU may be undercounting workingset
> refaults.
>
> This has impact on userspace programs, like Android's LMKD, that
> monitor workingset refault statistics to detect thrashing.
>
> It was found that refaults were only accounted if the MGLRU shadow
> entry was for a recently evicted folio. However, recently evicted
> folios should be accounted as workingset activation, and refaults
> should be accounted regardless of recency.
>
> Fix MGLRU's workingset refault and activation accounting to more
> closely match that of the conventional active/inactive LRU.
>
> Fixes: ac35a4902374 ("mm: multi-gen LRU: minimal implementation")
> Cc: Yu Zhao <yuzhao@...gle.com>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Reported-by: Charan Teja Kalla <quic_charante@...cinc.com>
> Signed-off-by: Kalesh Singh <kaleshsingh@...gle.com>

Acked-by: Yu Zhao <yuzhao@...gle.com>