linux-kernel - Re: [PATCH] md/raid5: Convert stripe_head's "dev" to flexible array member

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZGxU/zSGkqGhGWmF@infradead.org>
Date:   Mon, 22 May 2023 22:54:07 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Yu Kuai <yukuai1@...weicloud.com>
Cc:     Christoph Hellwig <hch@...radead.org>,
        Kees Cook <keescook@...omium.org>, Song Liu <song@...nel.org>,
        linux-raid@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-hardening@...r.kernel.org, "yukuai (C)" <yukuai3@...wei.com>
Subject: Re: [PATCH] md/raid5: Convert stripe_head's "dev" to flexible array
 member

On Mon, May 22, 2023 at 07:49:38PM +0800, Yu Kuai wrote:
> Hi, Christoph
> 
> 在 2023/05/18 12:27, Christoph Hellwig 写道:
> 
> It's not related to this patch, just I think I found a problem while
> reviewing raid5 code, commit e82ed3a4fbb5 ("md/raid6: refactor
> raid5_read_one_chunk") changes the caculation of 'end_sector',
> 'end_sector' is compared to 'rdev->recovery_offset', so it should be
> offset to rdev, but this commit change it to offset to the array.
> 
> Perhaps following change will make sense:

Yes, I think it does.  Can you send a patch?