linux-kernel - RE: [PATCH net 1/1] net: stmmac: Remove redundant checking for rx_coalesce

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM6PR11MB33060877F8CE38E1BA65EEA8B9409@DM6PR11MB3306.namprd11.prod.outlook.com>
Date:   Tue, 23 May 2023 06:05:25 +0000
From:   "Gan, Yi Fang" <yi.fang.gan@...el.com>
To:     Giuseppe Cavallaro <peppe.cavallaro@...com>,
        Alexandre Torgue <alexandre.torgue@...com>,
        Jose Abreu <joabreu@...opsys.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-stm32@...md-mailman.stormreply.com" 
        <linux-stm32@...md-mailman.stormreply.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Looi, Hong Aun" <hong.aun.looi@...el.com>,
        "Sit, Michael Wei Hong" <michael.wei.hong.sit@...el.com>
Subject: RE: [PATCH net 1/1] net: stmmac: Remove redundant checking for
 rx_coalesce_usecs



> -----Original Message-----
> From: Gan, Yi Fang <yi.fang.gan@...el.com>
> Sent: Tuesday, 23 May, 2023 11:56 AM
> To: Giuseppe Cavallaro <peppe.cavallaro@...com>; Alexandre Torgue
> <alexandre.torgue@...com>; Jose Abreu <joabreu@...opsys.com>; David S .
> Miller <davem@...emloft.net>; Jakub Kicinski <kuba@...nel.org>; Paolo
> Abeni <pabeni@...hat.com>; Maxime Coquelin
> <mcoquelin.stm32@...il.com>
> Cc: netdev@...r.kernel.org; linux-stm32@...md-mailman.stormreply.com;
> linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org; Looi, Hong
> Aun <hong.aun.looi@...el.com>; Sit, Michael Wei Hong
> <michael.wei.hong.sit@...el.com>; Gan, Yi Fang <yi.fang.gan@...el.com>
> Subject: [PATCH net 1/1] net: stmmac: Remove redundant checking for
> rx_coalesce_usecs
> 
> The datatype of rx_coalesce_usecs is u32, always larger or equal to zero.
> Previous checking does not include value 0, this patch removes the checking to
> handle the value 0.
> 
> Signed-off-by: Gan Yi Fang <yi.fang.gan@...el.com>
> ---
>  drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
> b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
> index 35c8dd92d369..6ed0e683b5e0 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
> @@ -917,7 +917,7 @@ static int __stmmac_set_coalesce(struct net_device
> *dev,
>  	else if (queue >= max_cnt)
>  		return -EINVAL;
> 
> -	if (priv->use_riwt && (ec->rx_coalesce_usecs > 0)) {
> +	if (priv->use_riwt) {
>  		rx_riwt = stmmac_usec2riwt(ec->rx_coalesce_usecs, priv);
> 
>  		if ((rx_riwt > MAX_DMA_RIWT) || (rx_riwt < MIN_DMA_RIWT))
> --
> 2.34.1

Hi All,

Please ignore this message. The patch is targeted for net-next instead of net.
Will resend for net-next.


Best Regards,
Gan Yi Fang