linux-kernel - Re: linux-next: build warning after merge of the scsi-mkp tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c7e0574e-bfb2-fee7-2467-5f9cd8d335f5@kernel.org>
Date:   Tue, 23 May 2023 15:38:16 +0900
From:   Damien Le Moal <dlemoal@...nel.org>
To:     Stephen Rothwell <sfr@...b.auug.org.au>,
        "Martin K. Petersen" <martin.petersen@...cle.com>
Cc:     Niklas Cassel <niklas.cassel@....com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: build warning after merge of the scsi-mkp tree

On 5/23/23 12:38, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the scsi-mkp tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> drivers/ata/libata-scsi.c:3864: warning: Function parameter or member 'spg' not described in 'ata_mselect_control'
> 
> Introduced by commit
> 
>   df60f9c64576 ("scsi: ata: libata: Add ATA feature control sub-page translation")
> 

Martin,

This is missing:

diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
index 69fc0d2c2123..c676b1e9b6c9 100644
--- a/drivers/ata/libata-scsi.c
+++ b/drivers/ata/libata-scsi.c
@@ -3850,6 +3850,7 @@ static unsigned int ata_mselect_control_ata_feature(struct
ata_queued_cmd *qc,
 /**
  *     ata_mselect_control - Simulate MODE SELECT for control page
  *     @qc: Storage for translated ATA taskfile
+ *     @spg: sub-page of the control page
  *     @buf: input buffer
  *     @len: number of valid bytes in the input buffer
  *     @fp: out parameter for the failed field on error

Do you want me to send a fix patch or can you fold this in ?

-- 
Damien Le Moal
Western Digital Research