linux-kernel - Re: [PATCH] dmaengine: pl330: rename

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230523-lushly-purr-9a93ea9f3573@wendy>
Date:   Tue, 23 May 2023 07:47:05 +0100
From:   Conor Dooley <conor.dooley@...rochip.com>
To:     Randy Dunlap <rdunlap@...radead.org>
CC:     <linux-kernel@...r.kernel.org>,
        Jaswinder Singh <jassisinghbrar@...il.com>,
        Jaswinder Singh <jassi.brar@...sung.com>,
        Boojin Kim <boojin.kim@...sung.com>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Russell King <rmk+kernel@....linux.org.uk>,
        Vinod Koul <vkoul@...nel.org>, <dmaengine@...r.kernel.org>,
        <linux-riscv@...ts.infradead.org>
Subject: Re: [PATCH] dmaengine: pl330: rename _start to prevent build error

Hey Randy,

On Mon, May 22, 2023 at 05:06:06PM -0700, Randy Dunlap wrote:
> "_start" is used in several arches and proably should be reserved
> for ARCH usage. Using it in a driver for a private symbol can cause
> a build error when it conflicts with ARCH usage of the same symbol.
> 
> Therefore rename pl330's "_start" to "_start_thread" so that there
> is no conflict and no build error.

_start_thread() seems pretty generic to me too, but there don't appear
to be any users & it is certainly better than the one causing build
issues!

Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>

Thanks,
Conor.

> 
> drivers/dma/pl330.c:1053:13: error: '_start' redeclared as different kind of symbol
>  1053 | static bool _start(struct pl330_thread *thrd)
>       |             ^~~~~~
> In file included from ../include/linux/interrupt.h:21,
>                  from ../drivers/dma/pl330.c:18:
> arch/riscv/include/asm/sections.h:11:13: note: previous declaration of '_start' with type 'char[]'
>    11 | extern char _start[];
>       |             ^~~~~~

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)