linux-kernel - Re: [PATCH] Revert "firmware: qcom_scm: Clear download bit during reboot"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bdef28ed-20f5-3996-55a5-0e955d4c6317@quicinc.com>
Date:   Tue, 23 May 2023 13:23:15 +0530
From:   Mukesh Ojha <quic_mojha@...cinc.com>
To:     Bjorn Andersson <andersson@...nel.org>,
        Robert Marko <robimarko@...il.com>
CC:     <agross@...nel.org>, <konrad.dybcio@...aro.org>,
        <p.zabel@...gutronix.de>, <linux-arm-msm@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Revert "firmware: qcom_scm: Clear download bit during
 reboot"

+Robert

On 5/20/2023 7:42 AM, Bjorn Andersson wrote:
> On Thu, May 18, 2023 at 04:50:23PM +0530, Mukesh Ojha wrote:
>> This reverts commit 781d32d1c970 as it causes regression(reboot
>> does not work) for target like IPQ4019 that does not support
>> download mode scm calls end to end.
>>
> 
> What do you mean with "reboot does not work"?
> 
> Does qcom_scm_set_download_mode() crash the board? Does the reboot
> always end up in download mode? Or some other form of "not work"?

As per the discussion here, it seems qcom_scm_set_download_mode()
does not work on some legacy target like IPQ4019..may be because
firmware does not have the support..

https://lore.kernel.org/lkml/76943268-3982-deaf-9736-429dd51e01b0@gmail.com/

-- Mukesh

> 
> Regards,
> Bjorn
> 
>> Fixes: 781d32d1c970 ("firmware: qcom_scm: Clear download bit during reboot")
>> Signed-off-by: Mukesh Ojha <quic_mojha@...cinc.com>
>> ---
>>   drivers/firmware/qcom_scm.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c
>> index fde33acd46b7..a4bb9265d9c0 100644
>> --- a/drivers/firmware/qcom_scm.c
>> +++ b/drivers/firmware/qcom_scm.c
>> @@ -1508,7 +1508,8 @@ static int qcom_scm_probe(struct platform_device *pdev)
>>   static void qcom_scm_shutdown(struct platform_device *pdev)
>>   {
>>   	/* Clean shutdown, disable download mode to allow normal restart */
>> -	qcom_scm_set_download_mode(false);
>> +	if (download_mode)
>> +		qcom_scm_set_download_mode(false);
>>   }
>>   
>>   static const struct of_device_id qcom_scm_dt_match[] = {
>> -- 
>> 2.7.4
>>