linux-kernel - Re: [PATCH v1] gpio: tangier: calculate number of ctx using temporary variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 23 May 2023 10:22:50 +0200
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     Raag Jadav <raag.jadav@...el.com>
Cc:     linus.walleij@...aro.org, andriy.shevchenko@...ux.intel.com,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        mallikarjunappa.sangannavar@...el.com, pandith.n@...el.com
Subject: Re: [PATCH v1] gpio: tangier: calculate number of ctx using temporary variable

On Mon, May 22, 2023 at 6:58 AM Raag Jadav <raag.jadav@...el.com> wrote:
>
> Utilize a temporary variable to calculate number of ctx from ngpio
> inside ->probe() implementation.
> While at it, include math.h for using DIV_ROUND_UP().
>
> Signed-off-by: Raag Jadav <raag.jadav@...el.com>
> ---
>  drivers/gpio/gpio-tangier.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-tangier.c b/drivers/gpio/gpio-tangier.c
> index e990781935ba..7ce3eddaed25 100644
> --- a/drivers/gpio/gpio-tangier.c
> +++ b/drivers/gpio/gpio-tangier.c
> @@ -16,6 +16,7 @@
>  #include <linux/interrupt.h>
>  #include <linux/io.h>
>  #include <linux/irq.h>
> +#include <linux/math.h>
>  #include <linux/module.h>
>  #include <linux/pinctrl/pinconf-generic.h>
>  #include <linux/spinlock.h>
> @@ -428,10 +429,11 @@ static int tng_gpio_add_pin_ranges(struct gpio_chip *chip)
>  int devm_tng_gpio_probe(struct device *dev, struct tng_gpio *gpio)
>  {
>         const struct tng_gpio_info *info = &gpio->info;
> +       size_t nctx = DIV_ROUND_UP(info->ngpio, 32);
>         struct gpio_irq_chip *girq;
>         int ret;
>
> -       gpio->ctx = devm_kcalloc(dev, DIV_ROUND_UP(info->ngpio, 32), sizeof(*gpio->ctx), GFP_KERNEL);
> +       gpio->ctx = devm_kcalloc(dev, nctx, sizeof(*gpio->ctx), GFP_KERNEL);
>         if (!gpio->ctx)
>                 return -ENOMEM;
>
> --
> 2.17.1
>

Applied, thanks!

Bartosz