linux-kernel - Re: [PATCH -next] gpio: brcmstb: Use devm_platform_get_and_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMRc=Mc4ifLQ-QB2v+hgMEc2P9pK-6uzDmOXfdP_g-jkjrCp7g@mail.gmail.com>
Date:   Tue, 23 May 2023 10:24:01 +0200
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     Yang Li <yang.lee@...ux.alibaba.com>
Cc:     linus.walleij@...aro.org, opendmb@...il.com, f.fainelli@...il.com,
        bcm-kernel-feedback-list@...adcom.com, linux-gpio@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] gpio: brcmstb: Use devm_platform_get_and_ioremap_resource()

On Fri, Apr 28, 2023 at 8:11 AM Yang Li <yang.lee@...ux.alibaba.com> wrote:
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
> ---
>  drivers/gpio/gpio-brcmstb.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-brcmstb.c b/drivers/gpio/gpio-brcmstb.c
> index c55b35da61a0..6566517fe0d8 100644
> --- a/drivers/gpio/gpio-brcmstb.c
> +++ b/drivers/gpio/gpio-brcmstb.c
> @@ -609,8 +609,7 @@ static int brcmstb_gpio_probe(struct platform_device *pdev)
>         platform_set_drvdata(pdev, priv);
>         INIT_LIST_HEAD(&priv->bank_list);
>
> -       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -       reg_base = devm_ioremap_resource(dev, res);
> +       reg_base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
>         if (IS_ERR(reg_base))
>                 return PTR_ERR(reg_base);
>
> --
> 2.20.1.7.g153144c
>

Applied, thanks!

Bart