linux-kernel - [PATCH] btrfs: fix uninitialized variable warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230523085935.713859-1-pengfuyuan@kylinos.cn>
Date:   Tue, 23 May 2023 16:59:35 +0800
From:   pengfuyuan <pengfuyuan@...inos.cn>
To:     Chris Mason <clm@...com>
Cc:     Josef Bacik <josef@...icpanda.com>,
        David Sterba <dsterba@...e.com>, linux-btrfs@...r.kernel.org,
        linux-kernel@...r.kernel.org, pengfuyuan <pengfuyuan@...inos.cn>,
        k2ci <kernel-bot@...inos.cn>
Subject: [PATCH] btrfs: fix uninitialized variable warnings


There are some warnings on older compilers (gcc 10, 7) or non-x86_64
architectures (mips64).  As btrfs wants to enable -Wmaybe-uninitialized
by default, fix the warnings even though it's not necessary on recent
compilers (gcc 12+).

    fs/btrfs/tree-log.c: In function ‘btrfs_log_inode’:
    fs/btrfs/tree-log.c:6211:9: error: ‘last_range_start’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
     6211 |   ret = insert_dir_log_key(trans, log, path, key.objectid,
          |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     6212 |       first_dir_index, last_dir_index);
          |       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    fs/btrfs/tree-log.c:6161:6: note: ‘last_range_start’ was declared here
     6161 |  u64 last_range_start;
          |      ^~~~~~~~~~~~~~~~
    cc1: all warnings being treated as errors

Reported-by: k2ci <kernel-bot@...inos.cn>
Signed-off-by: pengfuyuan <pengfuyuan@...inos.cn>
---
 fs/btrfs/tree-log.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/btrfs/tree-log.c b/fs/btrfs/tree-log.c
index 9b212e8c70cc..d2755d5e338b 100644
--- a/fs/btrfs/tree-log.c
+++ b/fs/btrfs/tree-log.c
@@ -6158,7 +6158,7 @@ static int log_delayed_deletions_incremental(struct btrfs_trans_handle *trans,
 {
 	struct btrfs_root *log = inode->root->log_root;
 	const struct btrfs_delayed_item *curr;
-	u64 last_range_start;
+	u64 last_range_start = 0;
 	u64 last_range_end = 0;
 	struct btrfs_key key;
 
-- 
2.25.1


Content-type: Text/plain

No virus found
		Checked by Hillstone Network AntiVirus