linux-kernel - Re: [PATCH] mips: Move initrd_start check after initrd address sanitisation.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230523090556.GA9484@alpha.franken.de>
Date:   Tue, 23 May 2023 11:05:56 +0200
From:   Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To:     Liviu Dudau <liviu@...au.co.uk>
Cc:     Paul Burton <paulburton@...nel.org>,
        John Crispin <john@...ozen.org>,
        Arınç ÜNAL <arinc.unal@...nc9.com>,
        Sergio Paracuellos <sergio.paracuellos@...il.com>,
        linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mips: Move initrd_start check after initrd address
 sanitisation.

On Tue, May 09, 2023 at 06:29:21PM +0100, Liviu Dudau wrote:
> PAGE_OFFSET is technically a virtual address so when checking the value of
> initrd_start against it we should make sure that it has been sanitised from
> the values passed by the bootloader. Without this change, even with a bootloader
> that passes correct addresses for an initrd, we are failing to load it on MT7621
> boards, for example.
> 
> Signed-off-by: Liviu Dudau <liviu@...au.co.uk>
> ---
>  arch/mips/kernel/setup.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)

applied to mips-fixes.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]