linux-kernel - Re: [PATCH v3] gpio: tegra186: Check GPIO pin permission before access.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMRc=MdCiieaYR3BeATm+2o8UDz+9D5vs=dTNDAavi19BmKZ8w@mail.gmail.com>
Date:   Tue, 23 May 2023 11:17:39 +0200
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     Jon Hunter <jonathanh@...dia.com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Prathamesh Shete <pshete@...dia.com>, thierry.reding@...il.com,
        bgolaszewski@...libre.com, linux-gpio@...r.kernel.org,
        linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org,
        smangipudi@...dia.com, kyarlagadda@...dia.com,
        Manish Bhardwaj <mbhardwaj@...dia.com>
Subject: Re: [PATCH v3] gpio: tegra186: Check GPIO pin permission before access.

On Tue, May 23, 2023 at 8:22 AM Jon Hunter <jonathanh@...dia.com> wrote:
>
>
> On 17/10/2022 10:31, Linus Walleij wrote:
> > On Fri, Oct 7, 2022 at 7:59 AM Prathamesh Shete <pshete@...dia.com> wrote:
> >
> >> This change checks if we have the necessary permission to
> >> access the GPIO. For devices that have support for virtualisation
> >> we need to check both the TEGRA186_GPIO_VM_REG and the
> >> TEGRA186_GPIO_SCR_REG registers. For device that do not have
> >> virtualisation support for GPIOs we only need to check the
> >> TEGRA186_GPIO_SCR_REG register.
> >>
> >> Signed-off-by: Manish Bhardwaj <mbhardwaj@...dia.com>
> >> Signed-off-by: Prathamesh Shete <pshete@...dia.com>
> >
> > Very nice patch!
> > Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
>
>
> I did not see this anywhere in the mainline/next. However, I also
> noticed that we don't have the correct email address for Bartosz (again).
>

I have only ever changed my address in MAINTAINERS once, so "again" is
not really the right term. And scripts/get_maintainer.pl should be
used anyway every time when submitting patches.

> Bartosz, let me know if you can pick this up? Thierry also ack'ed
> previously for Tegra too.
>
> FWIW ...
>
> Acked-by: Jon Hunter <jonathanh@...dia.com>
>

This doesn't apply to v6.4-rc1. Prathmesh: could you rebase and resend?

Bart

> Thanks
> Jon
>
> --
> nvpublic